Repository navigation
Conversation
RyanTheTide
left a comment
There was a problem hiding this comment.
The change is correct. permissions: contents: read covers every job: source, rust-build and kunit only check out and build, and none of them uses GITHUB_TOKEN or a secret. The concurrency group matches the dt-checks.yml and host-tests.yml pattern with its own sep-source- prefix.
The only remaining item: commit d81152f needs the submitter's Signed-off-by: (git commit --amend -s, push). Then mark the PR ready for review.
d81152f to
18561d5
Compare
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
18561d5 to
44daef4
Compare
The SEP source checks start a new source, rust-build and kunit run on every pull_request event, but unlike the device tree and host test workflows they have no concurrency group. A PR that is pushed again, or that receives two events for one head, keeps every earlier run going: in the last 100 runs ten heads were checked twice at the same SHA, and each kunit job builds a kernel and boots it in QEMU. Use the same per-PR concurrency group with cancel-in-progress as dt-checks.yml and host-tests.yml, and the same read-only contents permission. No job reads anything beyond the checkout. Assisted-by: LLM Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
44daef4 to
efeedfe
Compare
|
Ryan, the CI on 44daef4 fails because the PR is based on an old integration/aurora. The change itself only touches
I rebased the commit onto integration/aurora 8333109, which includes both fixes. The patch, commit message and sign-off are unchanged ( CI on the new head: pending. |
Summary
sep-source.ymlis the only one of the three workflows onintegration/aurorawithout a concurrency group or apermissionsblock. This adds both, copied fromdt-checks.ymlandhost-tests.yml:concurrency: sep-source-<PR number or ref>,cancel-in-progress: truepermissions: contents: readWhy
When this PR was opened (2026-11-10 UTC), ten heads in the last 100
SEP source checksruns had been checked twice at the same SHA. Examples:fix/t8140-slpddr-coproc-crashatb1c202a5,77014185and1814809b, andj713/radio-s2r-perstat170c1617. A push to a PR also leaves the earlierkunitjob running. Each of those jobs builds an arm64 kernel and boots it in QEMU, with a timeout of up to 60 minutes.No job writes anything back. They only check out the tree, so
contents: readis enough.Scope
sourcejob steps. All three are merged, and this PR is based on them.Testing
on,permissions,concurrencyandjobs..github/workflows/sep-source.yml, its own path filter runs the workflow on this PR.Update
Rebased onto
integration/auroraat125e6966. The diff is unchanged (patch-id97b7bee3). The commit's author name now matches its sign-off, and its AI trailer isAssisted-by: LLM, the form inDocumentation/process/coding-assistants.rst.