Skip to content

ci: sep-source: cancel superseded runs and use a read-only token - #1409

Open
techmore wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
techmore:ci/sep-source-concurrency-20261110
Open

techmore wants to merge 1 commit into
aurora-silicon:integration/aurorafrom
techmore:ci/sep-source-concurrency-20261110

Conversation

@techmore

@techmore techmore commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

sep-source.yml is the only one of the three workflows on integration/aurora without a concurrency group or a permissions block. This adds both, copied from dt-checks.yml and host-tests.yml:

  • concurrency: sep-source-<PR number or ref>, cancel-in-progress: true
  • permissions: contents: read

Why

When this PR was opened (2026-11-10 UTC), ten heads in the last 100 SEP source checks runs had been checked twice at the same SHA. Examples: fix/t8140-slpddr-coproc-crash at b1c202a5, 77014185 and 1814809b, and j713/radio-s2r-perst at 170c1617. A push to a PR also leaves the earlier kunit job running. Each of those jobs builds an arm64 kernel and boots it in QEMU, with a timeout of up to 60 minutes.

No job writes anything back. They only check out the tree, so contents: read is enough.

Scope

Testing

  • The YAML parses, and the top-level keys are on, permissions, concurrency and jobs.
  • Because this PR touches .github/workflows/sep-source.yml, its own path filter runs the workflow on this PR.

Update

Rebased onto integration/aurora at 125e6966. The diff is unchanged (patch-id 97b7bee3). The commit's author name now matches its sign-off, and its AI trailer is Assisted-by: LLM, the form in Documentation/process/coding-assistants.rst.

@RyanTheTide RyanTheTide left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is correct. permissions: contents: read covers every job: source, rust-build and kunit only check out and build, and none of them uses GITHUB_TOKEN or a secret. The concurrency group matches the dt-checks.yml and host-tests.yml pattern with its own sep-source- prefix.

The only remaining item: commit d81152f needs the submitter's Signed-off-by: (git commit --amend -s, push). Then mark the PR ready for review.

@techmore
techmore force-pushed the ci/sep-source-concurrency-20261110 branch from d81152f to 18561d5 Compare November 10, 2026 11:24
@techmore
techmore marked this pull request as ready for review November 10, 2026 11:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T11:32:42.460416Z 18561d5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@techmore
techmore force-pushed the ci/sep-source-concurrency-20261110 branch from 18561d5 to 44daef4 Compare November 11, 2026 22:14
The SEP source checks start a new source, rust-build and kunit run on
every pull_request event, but unlike the device tree and host test
workflows they have no concurrency group. A PR that is pushed again,
or that receives two events for one head, keeps every earlier run
going: in the last 100 runs ten heads were checked twice at the same
SHA, and each kunit job builds a kernel and boots it in QEMU.

Use the same per-PR concurrency group with cancel-in-progress as
dt-checks.yml and host-tests.yml, and the same read-only contents
permission. No job reads anything beyond the checkout.

Assisted-by: LLM
Signed-off-by: Sean Dolbec <sdolbec1@gmail.com>
@techmore
techmore force-pushed the ci/sep-source-concurrency-20261110 branch from 44daef4 to efeedfe Compare November 12, 2026 14:23
@techmore

Copy link
Copy Markdown
Contributor Author

Ryan, the Signed-off-by: was already there: 44daef4, which replaced d81152f, carries my sign-off, and so does the rebased head efeedfe below. I should have said so when I pushed 44daef4.

CI on 44daef4 fails because the PR is based on an old integration/aurora. The change itself only touches .github/workflows/sep-source.yml:

I rebased the commit onto integration/aurora 8333109, which includes both fixes. The patch, commit message and sign-off are unchanged (git range-diff 44daef4c^..44daef4c efeedfec^..efeedfec gives =). The new head is efeedfe.

CI on the new head: pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants