Repository navigation
arm64: dts: apple: t6041-j614c-j616c: run the PMP and its fast die loop - #1459
Conversation
The M4 Max boards leave the PMP, its DART, report region and mailbox,
and the PMC disabled, and have no pmp alias, so the loader does not pass
the PMP's values ("FDT: pmp not found in devtree") and nothing starts it.
The M4 Pro boards run it.
Do as they do: the pmp alias, so that the loader copies this Mac's PMP
values from the ADT and enables the PMP; the DART, report region and
mailbox; the PMC with apple,pmp; and the GPU on the PMP's GPU domain,
since a running PMP otherwise treats the GPU as off and holds it at its
lowest state.
On a J614c the loader passes 90 PMP tunables, the PMP firmware starts
("PMP started", report "PMP running (status 0x1)"), the PMC and its CLPC
bind, and the GPU runs compute and render work on pmp_gfx.
Signed-off-by: Jos Dehaes <jos.dehaes@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With the PMP running, the cpufreq clusters can take the fast die-temperature limit as the M4 Pro boards do: restore apple,fast-die-effort, which these boards deleted while the PMP did not run (without a running PMP the limit holds each cluster at a third of its power). The ADT (fast-die-ctrl-loop, temp-sensor) is the M4 Pro's: the PMP holds its hot-spot sensors at 110 C, and the sochot maximum is 125 C. On a J614c, four minutes of all-core NEON FMA load with every CPU zone disabled, so the PMP as the only throttle: TCMz settled at 112 C (113 C at most), the cluster limits moved within each second while every cooling state stayed at 0, P0 and P1 ran at 3.5-3.8 GHz, E at 2.59 GHz, and the fans ramped to about 4950/5350 rpm, as on macOS. The SMC sensors the zones read run a few degrees above the PMP's, so the zones move out of its way: switch-on at 112 C and control at 116 C, leaving hot at 120 C and critical at 125 C. Switched on from 75 C they took over from the PMP, trimming far below their control point: with control at 115 C the power allocator held the E cluster at 1.02 GHz. With 112/116 on the J614c, the same load: TCMz at 109-114 C, P0 and P1 at 3.5-3.8 GHz, E at 2.5-2.6 GHz, the zones trimming only briefly above 112 C, and the fans from cold to about 4950/5350 rpm. Signed-off-by: Jos Dehaes <jos.dehaes@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n#1459 Preserve the original contributor commits and integrate the already-merged NVRAM/SEP changes and preceding reviewed board additions. Resolve shared DTS insertion overlaps without dropping either side.
DjDeveloperr
left a comment
There was a problem hiding this comment.
No blocking findings after reviewing the shared SoC nodes, current CPU energy/thermal policy, PMC supplier dependency and cpufreq fallback. The pmp alias enables the existing loader tunable handoff, which sets status=okay only after locating the ADT PMP; the PMC apple,pmp link defers until the PMP is bound. Restoring the inherited three fast-die-effort lanes retains the cpufreq driver's limited-power fallback until PMP reports running. Moving the Linux CPU zones to 112/116 C leaves hot/critical trips, three-sample shutdown, sustainable-power values and cooling maps intact. The GPU power-domain vote follows its existing pmp_gfx/ps_gfx lifetime. J614c runtime measurements are attributed to the author; J616c hardware validation remains outstanding. The original head passed host-tests and dt-checks.
Resolved the shared DTS insertion conflicts by merging current integration and the preceding reviewed PRs into this branch, preserving the original contributor commits and all earlier merged changes. Each original patch hunk matched uniquely; the incremental changes are the original PR changes (plus removal of an empty line left at EOF by the camera move). Updated-head CI must pass before merge. Merge this series in order: #1459, #1463, #1464, #1465. No image build or hardware change was started.
75a666a
into
aurora-silicon:integration/aurora
Follows #1452. This PR runs the PMP on the M4 Max laptops and lets its fast die-temperature loop lead the CPU throttling, as the M4 Pro boards do. The #1452 zones then act only as a backstop.
Before: the M4 Max boards leave the PMP, PMC and their nodes disabled, and they have no
pmpalias. So aura doesn't pass the PMP values ("FDT: pmp not found in devtree"), nothing starts the PMP, andapple,fast-die-effortis deleted from all three cpufreq domains. Without a running PMP, that limit holds each cluster at a third of its power.Commit 1,
run the PMP: this adds the M4 Pro's setup:pmpalias;pmp_dart,pmp_reportandpmp_mbox;pmcwithapple,pmp;pmp_gfx.On the J614c, aura passes 90 PMP tunables. The PMP starts ("PMP started", "PMP running (status 0x1)"), the PMC and CLPC bind, and the GPU runs compute and render on
pmp_gfx.Commit 2,
let the PMP's fast die loop lead:apple,fast-die-effortis restored. The ADT'sfast-die-ctrl-loopandfast-die-ctrl-ce-mapare byte-identical to the J614s's: 110 °C target, same lanes.Measured on the J614c, four minutes of 16-thread NEON FMA load each:
TCMzmacOS, under the same load:
TCMz105–110 °C and fans at about 4950/5350 rpm.With this PR the cluster limits move within each second while the zones' cooling states stay at 0–2. So the PMP does the fast control, as on macOS and the M4 Pro.
Not tested: the J616c. It shares the dtsi. If its PMP didn't start, the fast-die fallback would hold its CPUs at a third of their power, and cpufreq warns after 30 s. Its ADT has the same
temp-sensorandfast-die-ctrl-loopas the J614c's. Could someone with a J616c (AxxzyWasTaken, astaff?) boot it there?🤖 Generated with Claude Code