Repository navigation
Conversation
… link The adopted link's suspend check admits only the J716c; the K116s is its OLED sibling with the same T6050 host and the N1 on port 0, and the first s2idle attempt there failed with -EBUSY from the noirq suspend. Let it through the same checks. Signed-off-by: Jens Axboe <axboe@kernel.dk>
The adopted-link s2idle check walked the whole bus and refused to suspend when any device had left D0. With a kernel-trained second port (the SD reader on the K116s) the PCI core puts that root port into D3hot, and suspend failed with -EBUSY. Only the devices that asked to stay awake, the N1's functions and their root port, need to remain in D0. Signed-off-by: Jens Axboe <axboe@kernel.dk>
sithglan
force-pushed
the
thomas/k116s-pcie-s2idle
branch
from
November 12, 2026 14:30
241ebbd to
4f65a0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base: integration/aurora (050f6a5). Two commits in pcie-apple's check for suspend-to-idle over an adopted link.
Tested by Jens on the K116s: s2idle with everything loaded, also while the camera streams, measured 3.6-3.9 W over 24 minutes against about 5.1 W awake idle. That measurement was on his kernel before the rebase and has not been repeated on the rebased one.
Build: arm64, LLVM 22;
drivers/pci/controller/pcie-apple.o, no warnings.Authorship. Jens Axboe wrote these commits and runs them on his K116s (16-inch MacBook Pro, M5 Pro, OLED; Mac17,12; stub macOS 27.2 26B8125). They come from his K116s bundle of 2026-11-11 (integration/aurora 254c9bd plus 34 commits, kernel 7.3.0 running on the machine). I rebased them onto integration/aurora 050f6a5 and removed the LLM co-author and session trailers. Jens has given his OK: the commits carry his Signed-off-by.