Repository navigation
arm64: dts: apple: t602x: give the first ANE DART its power domain - #1694
Draft
DjDeveloperr wants to merge 1 commit into
Draft
DjDeveloperr wants to merge 1 commit into
DjDeveloperr wants to merge 1 commit into
Conversation
ane_dart0 names the always-on ps_pmp, while the M2 device trees (macOS 27.2.1: J414s, J414c, J475d) give dart-ane0 the ANE-SYS-DART vote, parent ANE_SYS, and the engine votes ANE-SYS-V. The M1, M1 Pro/Max/Ultra and M2 ANE DARTs at the same place already name ps_ane_sys. With ps_pmp, nothing powers ANE_SYS before ane_dart0 probes. It is the first of the three ANE DARTs, and only ane_dart1 and ane_dart2 (ps_ane_cpu, a child of ps_ane_sys) bring ANE_SYS up. Its first register read then depends on the loader having left ANE_SYS on. When the loader has not, the read takes an SError and panics the boot in apple_dart_readl, as the T8132 scaler and JPEG DARTs did. Name ps_ane_sys. After probe nothing changes: ane_dart1 and ane_dart2 already hold ANE_SYS on. The ANE and its DARTs are enabled on the M2 Pro and M2 Max (J414s, J416s, J474s, J414c, J416c, J475c), where ane_dart0 binds today with ps_pmp. This change is build-checked only. Fixes: 49d05bc ("arm64: dts: apple: t602x: Add the die 0 ANE") Signed-off-by: Diljit Singh <hey@djdev.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1676, which carried this commit alongside four other DART power-domain fixes. The rest of #1676 can merge without it; this one waits for a T602x boot.
ane_dart0(iommu@285800000) names the always-onps_pmp. The M2 Pro/Max device trees givedart-ane0the ANE-SYS-DART vote under ANE_SYS, and the M1-family ANE DARTs at the same place already nameps_ane_sys. Withps_pmp, nothing powers ANE_SYS beforeane_dart0probes: onlyane_dart1andane_dart2(ps_ane_cpu, a child ofps_ane_sys) bring it up. The first register read then depends on the loader having left ANE_SYS on, and if it hasn't,apple_dart_readltakes an SError and the boot panics. This change namesps_ane_sysinstead.This has only been build-checked.
Needs one boot
Please boot this on any one of J414s, J416s, J474s, J414c, J416c or J475c and check that:
285800000.iommuprobes cleanly (no probe error indmesg)🤖 Generated with Claude Code