Repository navigation
phy: apple: atc: name the condition that stops the host for a sleep (#1682) - #1701
Merged
Merged
Conversation
When the USB host can't sleep in place, the debug line gave only the mode, the PIPE state and whether the host was active, which pass in the case of linux#1682 (mode 2, PIPE 1, host 1). Name every condition of atcphy_can_sleep_in_place() that fails as well. Signed-off-by: Diljit Singh <hey@djdev.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1682: when the USB host can't sleep in place, the PHY's debug line now names which condition of
atcphy_can_sleep_in_place()failed.In #1682's case,
mode 2, PIPE 1, host 1all pass, and the line said nothing more. Debug output only: no behaviour changes.898aac04phy: apple: atc: say which condition stops the host for a sleepno_sleep_power,dart_unlisted,pd_usb/pd_common,sleep_no_keep,host_inactive,mode,mode_dirty,pipe_pending,pipe_state,usb_off_pending,dp_owned_pmas,aux_power_requested,tunnel_users.USB controller stops for the sleep: mode 2, PIPE 1, host 1, because: pipe_pending.Built and booted on the Neo (J700) on 2026-11-12, as part of a kit on
cae47c00, withfile atc.c +p.🤖 Generated with Claude Code