Repository navigation
Conversation
The first ISP DART filters the ISP firmware's accesses to the PMGR, PMP and DSID windows it uses. The boot loader programs that filter, and it goes off with the ISP system domain. Describe its register window and the loader's ranges, from the J813 ADT's dart-isp dapf-instance-0 in the ADT's order, with each entry's last word (0xcc3), so the DART driver writes them back when the DART powers up again. Assisted-by: Claude Fable 5.2 Signed-off-by: Kyle Arrington <kyle@arrington.co>
T8142 kept its firmware resident, so the ISP domains stayed on from boot to shutdown. It runs T8140's coprocessor and firmware interface. Use the model T6040 got: the firmware stops after the camera detection at probe, each stream starts it again from its own memory, and it stays up for 5 s after a stream. The coprocessor is quiesced before its domains go off. A device tree without the ISP DART's address filter ranges keeps the firmware resident, as before. Assisted-by: Claude Fable 5.2 Signed-off-by: Kyle Arrington <kyle@arrington.co>
Contributor
|
@gig3m Checked against the J815 ADT (Mac17,4, macOS 27.0 stub). J815's
So the shared Assisted-by: Claude Opus 5.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T8142 kept its ISP firmware resident, so the ISP power domains stayed on from boot to shutdown and the ISP never runtime-suspended. This is #1827's change for T8142.
arm64: dts: apple: t8142-j813: describe the first ISP DART's address filter: thedapfregister window and the ranges from the J813 ADT's dart-isp dapf-instance-0. On this chip every entry's last word is 0xcc3, soapple,dapf-r20is given too. The registers the loader leaves on J813 read back the same ranges and 0xcc3.media: apple: isp: T8142 uses the model T6040 got: the firmware stops after the camera detection at probe, each stream starts it again, 5 s idle stop after a stream, coprocessor quiesce before the power-down.Tested on J813 (Mac17,3, 27.0 stub), integration/aurora 5d112b1 merged with #1532 at 0434a61, plus these two commits:
Not tested: J815. It includes the same
t8142-j813-isp.dtsi, so it gets the DART change too; I have not read its ADT. @m0d16l14n1, if you have time, could you check the dart-ispdapf-instance-0ranges and a stream on your J815? Also not done: KUnit, and a real sleep (only s2idle exists here).checkpatch --strict is clean.
Assisted-by: Claude Fable 5.2