Repository navigation
Conversation
The sensor reports on its own at the interval the driver sets at probe, and each report is an AOP mailbox interrupt. Nothing set the interval back to zero: the sensor kept reporting after the driver was unbound, and through suspend-to-idle, where it woke a CPU five times a second. Set the interval to zero on unbind and on system suspend, and back on resume. Assisted-by: Claude Fable 5.2 Signed-off-by: Kyle Arrington <kyle@arrington.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ALS reports on its own at the interval the driver sets at probe (200 ms), and each report is an AOP mailbox interrupt. Nothing set the interval back to zero, so:
This sets the interval to zero on unbind and in
.suspend, and back in.resume.Draft, because I can test one machine and this driver serves several. Feedback wanted on:
aop.rsstops the endpoints insuspend_latefor a firmware sleep; this runs before that, in.suspend. I could only test s2idle.Tested on J813 (Mac17,3, 27.0 stub, VD6286), integration/aurora 5d112b1 merged with #1532:
Not tested: any other Mac, a failed interval write on resume (it now warns).
Assisted-by: Claude Fable 5.2