Skip to content

soc: apple: clpc: count how often the GPU floor is released and comes back #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DjDeveloperr merged 1 commit into from
Oct 28, 2026
Merged

soc: apple: clpc: count how often the GPU floor is released and comes back #552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 31 additions & 5 deletions drivers/soc/apple/clpc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,13 @@ struct apple_clpc {
/* Whether, and when, the PMP last limited the DCS while GPU work streamed */
bool gpu_limited;
unsigned long gpu_limited_at;
/*
* Whether the GPU floor was released at the last sample that saw GPU work
* stream, and how often it was released and came back, for debugfs.
*/
bool gpu_floor_released;
unsigned long gpu_floor_releases;
unsigned long gpu_floor_returns;
};

/* Protect publication/removal of provider drvdata, never a submission path. */
Expand Down Expand Up @@ -427,6 +434,18 @@ static bool apple_clpc_gpu_limited(struct apple_clpc *clpc, unsigned long now)
msecs_to_jiffies(APPLE_CLPC_GPU_BACKOFF_MS));
}

/* Count the GPU floor's releases and returns while GPU work streams. */
static void apple_clpc_gpu_floor_count(struct apple_clpc *clpc, bool released)
{
if (released == clpc->gpu_floor_released)
return;
if (released)
clpc->gpu_floor_releases++;
else
clpc->gpu_floor_returns++;
clpc->gpu_floor_released = released;
}

static void apple_clpc_sample(struct apple_clpc *clpc)
{
unsigned int demand[APPLE_CLPC_RAILS] = {};
Expand Down Expand Up @@ -462,11 +481,16 @@ static void apple_clpc_sample(struct apple_clpc *clpc)
clpc->hw->map[rail][APPLE_CLPC_LEVELS - 1]);
}
}
if (clpc->gpu_pmgr && apple_clpc_gpu_streaming(clpc, now) &&
!apple_clpc_gpu_limited(clpc, now)) {
reason |= 4;
for (rail = 0; rail < APPLE_CLPC_RAILS; rail++)
demand[rail] = max(demand[rail], clpc->hw->gpu[rail]);
if (clpc->gpu_pmgr && apple_clpc_gpu_streaming(clpc, now)) {
bool released = apple_clpc_gpu_limited(clpc, now);

apple_clpc_gpu_floor_count(clpc, released);
if (!released) {
reason |= 4;
for (rail = 0; rail < APPLE_CLPC_RAILS; rail++)
demand[rail] = max(demand[rail],
clpc->hw->gpu[rail]);
}
}

for (rail = 0; rail < APPLE_CLPC_RAILS; rail++)
Expand Down Expand Up @@ -543,6 +567,8 @@ static int apple_clpc_status_show(struct seq_file *s, void *unused)
jiffies_to_msecs(jiffies - clpc->gpu_limited_at));
else
seq_puts(s, "never\n");
seq_printf(s, "gpu floor releases: %lu returns: %lu\n",
clpc->gpu_floor_releases, clpc->gpu_floor_returns);
}
for (i = 0; i < clpc->nr_clusters; i++)
seq_printf(s, "cluster cpu%u: busy %u%% level %u%% -> dcs %u soc %u\n",
Expand Down