Repository navigation
arm64: dts: apple: t6040-j616s: enable the QSPI power state - #691
Merged
Merged
Conversation
Commit 3d9601c ("arm64: dts: apple: t6040-j616s: enable the boot NOR and its nvram") enabled the QSPI controller but left its power state, ps_qspi, disabled as the SoC .dtsi describes it. The controller then waits on a supplier that never probes, and fails after the deferred probe timeout: apple-qspi 429118000.spi: probe with driver apple-qspi failed with error -110 Enable ps_qspi on the board that describes its flash. With this, the boot NOR and its nvram partition probe at about 5 s on a J616s. Fixes: 3d9601c ("arm64: dts: apple: t6040-j616s: enable the boot NOR and its nvram") Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The J616s boot NOR from 3d9601c never probes. The commit enabled
&qspibut its power stateps_qspistays disabled, ast6040-pmgr.dtsileaves it. The controller then waits on a supplier that never comes up and fails after the deferred probe timeout:This enables
ps_qspion the board, next to the flash it serves. The J700 already has itsps_qspienabled.Tested on a J616s
Tested with fleet12b (aurora-wip ec02113 + candidates, no #628 revert) on the refreshed J616s Stage 2. That DTB is the #662/#674 kit DTB with only this status changed, using the same loader bytes as the running 1.0.0b1 Stage 2.
spi-nor spi0.0probes at 5.2 s,/proc/mtdlistsmtd3: 00100000 00001000 "nvram",apple-qspiis bound, and kernel -p3 is 0.aurora-diag check --expect: 211 pass, 0 fail.make apple/t6040-j616s.dtbbuilds, and the output hasqspipower-controller@1e8okay.🤖 Generated with Claude Code