Repository navigation
tools/asahi: extract the AVD AV1 reference timestamp helper - #751
Closed
RyanTheTide wants to merge 1 commit into
Closed
RyanTheTide wants to merge 1 commit into
RyanTheTide wants to merge 1 commit into
Conversation
Commit 89e658c ("media: apple: avd: bound AV1 reference indices before using them") moved the reference timestamp lookup in avd_av1_set_prob() into a new u64 helper, avd_av1_ref_ts(). The AV1 tail host test only extracts int and void functions and did not list the helper, so the generated controls.c no longer compiled and all ten avd-av1-tail-tests cases failed in run-host-tests.py (148/158). Teach the extractor u64 return types, extract avd_av1_ref_ts() ahead of avd_av1_set_prob(), and give the fixture the u64 and U64_MAX it needs. The base run passes again and each of the six mutations still fails on its own assertion. Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
Contributor
Author
|
Full |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aurora-wip at 5cf4c5e fails 10 of 158 host tests: every
avd-av1-tail-testscase. #725's 89e658c moved the AV1 reference timestamp lookup into a newu64helper,avd_av1_ref_ts(). The test's extractor only matchesint/voidfunctions and did not list the helper, so the generatedcontrols.cstops compiling (implicit declaration of function 'avd_av1_ref_ts').This is a fixture-only change:
u64return types;avd_av1_ref_ts()is extracted ahead ofavd_av1_set_prob();u64andU64_MAX.No driver code changes.
Testing (buildbox, on aurora-wip 5cf4c5e plus this commit):
python3 -I -B tools/asahi/avd-av1-tail-tests.py: 1804 production controls PASS.tools/asahi/run-host-tests.pyresult is in the comments below.Found while building the fleet14 kernel; the host tests are a merge gate for it.
🤖 Generated with Claude Code