Repository navigation
media: apple: avd: Say when the queue info block is missing - #903
Merged
RyanTheTide merged 1 commit intoNov 5, 2026
Merged
RyanTheTide merged 1 commit into
RyanTheTide merged 1 commit into
Conversation
avd_qfw_check() returns false without a word when the firmware wrote no queue info block, and the decoder stays on the legacy transport. That is expected for a legacy image. But an ABI 2 image writes the block at its own SRAM address, so a DT sram window that does not match the image fails the same silent way. The other reasons for staying on the legacy transport (an unsupported ABI, a wrong image tier, a bad ring geometry) are already logged. Log this one once too. Signed-off-by: AxxzyWasTaken <axxzytte@gmail.com>
Contributor
|
Merge train (MTL, 06/11). Gates passed on test tree 0412501 (integration/aurora 2661d71 + this batch):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avd_qfw_check()returns false without logging anything when the firmware wrote no queue info block, so the decoder stays on the legacy transport and nothing in the log says so. For a legacy image that's expected. But an ABI 2 image writes the block at its own SRAM address, so a DTsramwindow that doesn't match the image fails the same silent way. The other reasons for staying on legacy (unsupported ABI, wrong image tier, bad ring geometry) are already logged.This logs the missing block once:
How it came up
On a J616C (T6041, M4 Max) running avd-fw 6062e851, the decoder stayed on
open-compatwith no message at all. The board's DT hadsramat 0x281092000 (the T8132 layout). The image's info block, with theAVQ1andAVM2magics, turned up at 0x28109bfc0, which is +0x7fc0 from 0x281094000: the T6040 layout, as int6040.dtsi. With the window moved to 0x281094000 (a test module that offset it), the driver readABI 2 aperture 0x1094000 features 0xfand switched toopen-queue. With this line it would have been a one-step find.Testing (J616C, M4 Max, 7.2.10, avd-fw 6062e851 v5-t2)
W=1: no warnings.