Repository navigation
nvmem: apple-spmi: populate the RTC child of a Chapel PMIC - #930
RyanTheTide merged 1 commit into
Conversation
|
Merge train (MTL, 06/11): can't take this yet. Commit 40fada3 ("nvmem: apple-spmi: populate the RTC child of a Chapel PMIC") has no |
apple-pmu-rtc binds to the rtc child of the PMU's SPMI node, but the nvmem driver only populates children on Baku and Abbey PMICs. J616C's PMU is a Chapel with the Abbey alarm layout, so the node never became a device and the machine had no RTC wake alarm. Populate the children of a Chapel PMIC too. Signed-off-by: AxxzyWasTaken <axxzytte@gmail.com>
40fada3 to
e9fa432
Compare
|
Signed off and force-pushed. No code change. |
|
Merge train (MTR, 06/11): merging, now signed off. This adds one compatible to the populate check, so Baku and Abbey PMICs behave exactly as before. The hardware proof is the author's J616C test: Gates: test merge 2d3579ef = integration/aurora 11eccbe + #1005 #994 #930 #658 #992 #1006 #1007 #1008 #531 (#992 has since landed on its own); base 11eccbe.
Hardware (7.3.0-aurora-mtr1106a, one-shot boots, fleet recipe):
|
apple-pmu-rtcbinds to thertcchild of the PMU's SPMI node, butapple-spmi-nvmemonly populates children on Baku and Abbey PMICs. J616C (M4 Max) has a Chapel PMU with the Abbey alarm layout, so the node in #914 never became a device, and the machine had no RTC wake alarm.This populates the children of a Chapel PMIC too.
Testing
On a 32-core J616C, with #914's device tree on a slightly older 7.3 base:
rtc1registers asapple-pmu-rtcwith awakealarm.The driver also compiles on the current base.