Repository navigation
selftests: asahi-m4: model publication power reports - #991
Merged
RyanTheTide merged 1 commit intoNov 5, 2026
Merged
RyanTheTide merged 1 commit into
RyanTheTide merged 1 commit into
Conversation
The publication fixture extracts Firmware::publish() verbatim but its Firmware mock has no power field. The utilization governor added a power.report_work() call, so test-publication.py fails to compile with E0609 instead of exercising publication and error isolation. Add a CPU-only recorder at the power reporting boundary and check the reports in the existing live, drained and deferred publication cases. The governor and CLPC transport remain outside this fixture. Fixes: 26fd983 ("drm/asahi: g16: Govern the published performance state by utilization") Assisted-by: LLM Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
RyanTheTide
marked this pull request as ready for review
November 5, 2026 14:05
Contributor
Author
RyanTheTide
deleted the
ctl/t-4732-fix-host-selftest-fixture-drift-on-integration-a
branch
November 5, 2026 14:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-publication.pyextractsFirmware::publish()verbatim, but its mockFirmwarehas nopowerfield for thereport_work()call added by the utilization governor. The fixture therefore fails with Rust E0609 before its publication and error-isolation checks run.Add a CPU-only power-report recorder and assert live, drained, and deferred work reports in the existing cases. This changes only the fixture harness; the production driver functions remain extracted verbatim.
The apple-dcp fixture failures from the same host-gate report are already fixed by #987, which is included in this branch's integration base.
Validation at d27965e on the controller-managed build host:
self.power.report_work().python3 tools/asahi/run-host-tests.py --jobs 8: 183/183 passed, including apple-dcp 85/85 and asahi-m4 23/23 with no skips.run.py: 85/85 passed.git diff --check: passed.The build source is shallow; historical revisions required by the existing controls were fetched explicitly before verification. No test expectations or production sources were changed for that setup.