chore: raise Apple deployment targets and bump CI to Xcode 26.6 / macos-26 - #352
Merged
Merged
Conversation
NandanPrabhu
had a problem deploying
to
internal
August 28, 2026 08:33 — with
GitHub Actions
Failure
NandanPrabhu
force-pushed
the
chore/raise-apple-deployment-targets-ios15
branch
from
August 28, 2026 08:56
369c89b to
d6e94a9
Compare
NandanPrabhu
had a problem deploying
to
internal
August 28, 2026 08:56 — with
GitHub Actions
Failure
sanchitmehtagit
previously approved these changes
Aug 28, 2026
NandanPrabhu
had a problem deploying
to
internal
August 28, 2026 11:37 — with
GitHub Actions
Failure
…os-26 Raise minimum platform versions to current stable minus four shipped majors (walked back through shipped majors, not arithmetic): - iOS 14 -> 15 - macOS 11 -> 12 - tvOS 14 -> 15 - watchOS 7 -> 8 - visionOS: unchanged at 1.0 (only 3 majors shipped, clamped to oldest) Also move CI off the deprecated macos-14 runner to macos-26 (preserving the -xlarge tier on pod-lint) and bump Xcode 16.1 -> 26.6. Updated: Package.swift, SimpleKeychain.podspec, project.pbxproj (only values below the new floor), README requirements + Support Policy example, and .github/workflows/main.yml.
keys() returns keychain items in the order SecItemCopyMatching yields, which the Security framework does not guarantee. The test asserted exact ordered equality against insertion order, making it flaky across platforms/runs. Compare sorted arrays instead (still count- and duplicate-sensitive).
NandanPrabhu
force-pushed
the
chore/raise-apple-deployment-targets-ios15
branch
from
August 31, 2026 05:33
1748e5d to
8cc81b6
Compare
The policy is 'last four major versions including the current major' (26/18/17/16 for iOS), so the floor is one higher than the previous commit: - iOS 15 -> 16 - macOS 12 -> 13 - tvOS 15 -> 16 - watchOS 8 -> 9 Also reword the Support Policy example: the previous text referenced iOS 19, which will never ship (Apple jumped iOS 18 -> iOS 26), so replace the specific future-version number with a description of the policy condition instead.
NandanPrabhu
force-pushed
the
chore/raise-apple-deployment-targets-ios15
branch
from
August 31, 2026 08:28
bc11609 to
8ac07dc
Compare
subhankarmaiti
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raises the minimum Apple platform versions to the last four major versions including the current (derived by walking the list of shipped majors, not `current − 4` arithmetic), and moves CI off the deprecated `macos-14` runner.
Walk-back (4 including current): iOS 26/18/17/16, macOS 26/15/14/13, tvOS 26/18/17/16, watchOS 26/11/10/9.
CI: Xcode
16.1 → 26.6; runnersmacos-14 → macos-26(andmacos-14-xlarge → macos-26-xlargeonpod-lint, tier preserved).Files:
Package.swift,SimpleKeychain.podspec,SimpleKeychain.xcodeproj/project.pbxproj(only values below the new floor),README.md(requirements + Support Policy example),.github/workflows/main.yml.Also fixes a flaky test:
testRetrievingKeysasserted exact ordered equality on keychain key enumeration order, which the Security framework doesn't guarantee. Changed to compare sorted arrays.Verification
swift build✅ ·swift test✅ 96/0 · macOS xcodebuild ✅ 96/0 · watchOS build ✅ ·pod lib lint✅ (builds all 5 platforms incl. watchOS/visionOS at new floors)error:lines); both confirmed compiling via cleanxcodebuild build.