Repository navigation
Say what the pre-pending marker test actually proves - #13
Merged
Merged
Conversation
The test claimed its 8s gate turned "noticed late" into an unmissably slow run. It does not. Without the evalOnce entry checkpoint the poll still fires at ~500ms, and the abort listener Runner registers kills the gate subprocess mid-flight, so the same verdict arrives at roughly the same speed by an older route — the whole-branch review traced this and measured it at ~840ms. So the test passes with or without the fix it sat next to, and its comment implied otherwise. That is the worse failure: a reader trusting it would believe the checkpoint was covered here, and delete the unit test in pipeline.test.js that actually discriminates. Both stay, and the comments now say which does what. The timing ceiling keeps its point — an eval that sat through the gate would blow it whichever route noticed the marker — and says to raise it rather than trim the gate if windows-latest ever flakes. Comment-only; no test or source behaviour changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FV5Usy3xLiz4ngEp6zPC5L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI test for an already-pending forced-stop marker carried a comment claiming its 8s test gate turned "noticed late" into an unmissably slow run. It doesn't.
Without the
evalOnceentry checkpoint, the poll still fires at ~500ms and the abort listenerRunnerregisters kills the gate subprocess mid-flight — so the same verdict arrives at roughly the same speed by an older route. The 0.2.2 whole-branch review traced this and measured it at ~840ms.So the test passes with or without the fix it sits next to, and its comment implied the opposite. That's the harmful direction: a reader trusting it would believe the checkpoint was covered there, and delete the unit test in
pipeline.test.jsthat actually discriminates.Both tests stay. The comments now say which one guards the end-to-end contract and which one guards the fix. The timing ceiling keeps its purpose — an eval that sat through the gate would blow it whichever route noticed the marker — and now says to raise the ceiling rather than trim the gate if
windows-latestever flakes.Comment-only. No test or source behaviour changes;
git diffhas no non-comment lines. Test files aren't in the published tarball, so no release is needed.🤖 Generated with Claude Code
https://claude.ai/code/session_01FV5Usy3xLiz4ngEp6zPC5L