Conversation
yacovm
changed the title
yacovm
force-pushed
the
rebroadcastEquivocation
branch
2 times, most recently
from
September 18, 2026 16:50
cfc45b3 to
b065f09
Compare
yacovm
changed the title
yacovm
force-pushed
the
rebroadcastEquivocation
branch
4 times, most recently
from
September 18, 2026 19:05
c0611a9 to
5a39dcd
Compare
The node may periodically re-broadcast a finalize vote on a round that it has notarized but not finalized. This is to re-broadcast finalize votes lost in the network. If the node has a notarization for the round but has not stored the finalize vote, it will create the finalize vote on its own before sending it. However, a node may also replicate a notarization from another node. A node should not send a finalize vote if it has timed out on a round, otherwise there is a safety violation. This commit removes the re-broadcast of finalize votes altogether, because it is not redundant thanks to the mechanism which makes nodes build empty blocks once a tip of the chain is notarized but not finalized. We just change the mechanism to also take into account blocks that we haven't timed out on in the middle of the chain are notarized but not finalized, and not only in the tip of the chain. We also make a replicated notarization send a finalize vote in case we haven't timed out on the round. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
yacovm
force-pushed
the
rebroadcastEquivocation
branch
from
September 18, 2026 19:33
5a39dcd to
3b38ce7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The node may periodically re-broadcast a finalize vote on a round that it has notarized but not finalized. This is to re-broadcast finalize votes lost in the network.
If the node has a notarization for the round but has not stored the finalize vote, it will create the finalize vote on its own before sending it.
However, a node may also replicate a notarization from another node.
A node should not send a finalize vote if it has timed out on a round, otherwise there is a safety violation.
This commit removes the re-broadcast of finalize votes altogether, because it is not redundant thanks to the mechanism which makes nodes build empty blocks once a tip of the chain is notarized but not finalized.
We just change the mechanism to also take into account blocks that we haven't timed out on in the middle of the chain are notarized but not finalized, and not only in the tip of the chain.