Repository navigation
fix: taxonomy fields with the agentic distinction for the seven JUSTIFY records (#444) - #445
Merged
Merged
Conversation
…FY records (#444) Signed-off-by: chaksaray <chaksaray@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #444.
Adds
security_boundary,missing_controlandvulnerability_rationaleto the seven JUSTIFY records (AVE-2026-00004, 00005, 00033, 00040, 00047, 00073, 00075), additively, in the shape AVE-2026-00087 uses and beforemitigation. Following the maintainer's decision of 2026-11-04, the agentic distinction is written intovulnerability_rationale.vulnerability; an optionalagentic_distinctionfield is for schema 2.0.0. No fingerprint, score, mapping, status or reference is touched.Per record
vulnerabilitysecurity_boundary,missing_control,capabilityand the first part ofvulnerabilityare the audit's text for the record, with the first word of the two phrases lower-cased and their closing full stop dropped, as in the template. The distinction sentences are the audit's and the decision memo's, restated for the record.impactis written from the record's own description, close to its words. 00040's comes from the audit's Q7 block.vulnerabilitystates the CVE case the record itself cites.Checked
python scripts/check_vulnerability_taxonomy.py: 16 of 89 records missing the fields before, 9 after;--strict --onlypasses for each of the seven.python -m pytest tests -qandvalidate_records.pypass;check_revisions_ratchet.py --ratchet-since origin/developpasses (no severity, status or derived basis changed, so no revisions entry is needed).origin/developonly insecurity_boundary,missing_control,vulnerability_rationaleandlast_updated, proved by parsing both versions; each diff is 8 added lines and thelast_updatedline (set to 2026-11-04, as CONTRIBUTING's "Improving existing records" says). Records were edited by exact text insertion, notjson.dumps.dist/andschema/are untouched: the workflow that regeneratesdist/opens that pull request after a merge. No em dashes added.Not done, and not checked
find_primary_source, a separate task.docs/decisions/quality-queue.jsonstill lists these seven records'add_taxonomy_fieldsandwrite_rationaleactions; it is refreshed separately once the batches are in.