Skip to content

fix(computer-use): synchronize standalone v0.7.59 - #69

Merged
avifenesh merged 1 commit into
mainfrom
fix/cul-sync-0.7.59
Nov 20, 2026
Merged

avifenesh merged 1 commit into
mainfrom
fix/cul-sync-0.7.59

Conversation

@avifenesh

@avifenesh avifenesh commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

Synchronize the embedded Computer Use backend to standalone v0.7.59 (agent-sh/computer-use-linux#493, ilysenko#494).

  • KDE Plasma Wayland (KWin 6.3+) pen and touch routes kwin-pen/kwin-touch in virtual_pen, the KWin stacking, desktop, activity and effect checks in windowing/backends/kwin.rs, and the opt-in KWin fixture (scripts/virtual_pen_kwin_test.py, its Dockerfile).
  • GNOME 48+ stylus button actions set for the server's own pen, so right and middle clicks arrive as sent; the pen leaves proximity after each action, so a scroll right after a click pans.
  • Codex glue: device names stay codex-computer-use-linux virtual pen/touch (so KWin's kcminputrc group carries that name and the cleanup matches it), the Codex extension named in the pen messages, the overlay filter matches the fork's codex-computer-use-indicator binary, the KWin fixture looks for that binary and also clears CODEX_COMPUTER_USE_INDICATOR, and the test binary is codex-computer-use-linux. Pen and touch successes still go through pointer_action_result. Three rejected hunks (pen refusal text, doctor note, test header) were rebuilt from the standalone files plus this glue.
  • Crate, Cargo.lock and the server.rs literal at 0.7.59; CHANGELOG, docs/linux-computer-use.md and the feature README updated.

Local (dev box): cargo fmt --check, cargo clippy -p codex-computer-use-linux --all-targets -- -D warnings clean; cargo test -p codex-computer-use-linux --all-targets --no-fail-fast -- --test-threads=1: 852 lib tests pass (6 ignored), every integration binary passes (the GNOME and KWin pen fixtures are opt-in and skip).

Closes agent-sh/computer-use-linux#495
Closes agent-sh/computer-use-linux#497

@avifenesh

Copy link
Copy Markdown
Owner Author

Independent review (fresh context, read-only)

Verdict: PASS. Nothing blocks the merge.

Checked:

  • Env: no new COMPUTER_USE_LINUX_* reads in src (the only new env read is PATH); COMPUTER_USE_LINUX_TEST_KWIN_SEAT is fixture-only, and the fixtures clear both indicator variables.
  • Avatar cursor: the pen and touch success path in background_pen returns pointer_action_result(successful_action_with_focus(...)); click, scroll and drag all go through it.
  • Naming: user-facing strings name codex-computer-use-indicator and the Codex GNOME Shell extension; PEN_NAME/TOUCH_NAME are the Codex names, and device creation and the kcminputrc cleanup groups both use those constants, with no hardcoded device names. The pen lock keeps the standalone name on purpose.
  • Port fidelity: the Dockerfile, virtual_pen_test.py, diagnostics.rs, kwin.rs and tests/virtual_pen.rs differ from standalone only by existing glue; server.rs (with the hand-rebuilt reject) only by that glue, the version literal, the indicator binary name and the extension message; virtual_pen.rs only by the device names and extension wording; virtual_pen_kwin_test.py only by the Codex indicator name and env.
  • Housekeeping: no .orig/.rej or untracked files; Cargo.lock changes only the crate version.

Non-blocking, left as is: the KWin fixture matches the device names by the standalone substring (still matches the Codex names), and the pen-busy message says "another computer-use-linux server", which pairs with the shared lock file and predates this sync.

@avifenesh
avifenesh merged commit 5d7cdc2 into main Nov 20, 2026
14 checks passed
@avifenesh
avifenesh deleted the fix/cul-sync-0.7.59 branch November 20, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync codex-desktop-linux with v0.7.59 release content Sync Computer Use → codex-desktop-linux embedded copy

1 participant