Skip to content

style: reset UI to shadcn Sera and swap Lucide for Tabler - #465

Merged
az3ta merged 5 commits into
dev-designfrom
chore/ui-sera-reset
Nov 3, 2026
Merged

az3ta merged 5 commits into
dev-designfrom
chore/ui-sera-reset

Conversation

@az3ta

@az3ta az3ta commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Resets the shared UI to the shadcn Sera preset (beXRToEi: Sera, zinc, Tabler, Geist Mono, Base UI) so there is one clean starting point to restyle from.

packages/ui/
├── styles/globals.css   # shadcn/tailwind.css import, Sera radius scale, no arbitrary values
└── components/          # regenerated from the Sera registry (23 components)
                         # kept local: slider, tooltip, drawer (vaul), checkbox, switch,
                         #   radio-group, toggle, label (restyled to Sera tokens)
apps/radio, apps/web     # ~110 rounded-* classes removed so Sera's square corners show
                         # lucide-react -> @tabler/icons-react (62 files, 83 icons)
-import { Trash2Icon } from "lucide-react";
+import { IconTrash } from "@tabler/icons-react";

Kept on purpose: rounded-full on radio-group (from Sera) and on custom components (knob, play-pause-button, changelog/What's new dots, midi-badge, peak-meter, platform dot). Remaining arbitrary values (16 in packages/ui, 32 in apps) are structural (calc, inherit, grid templates, viewport sizes).

Deviations from the registry: light --destructive is oklch(0.52 …) instead of Sera's 0.577 so destructive text passes the 4.5:1 contrast check in the Storybook a11y tests; secondary button hover is hover:bg-secondary/80 (registry uses an arbitrary color-mix); tooltip keeps its existing sideOffset/delay props; radio-group keeps the nativeButton fix like checkbox and switch.

Evidence

  • Before: no automated check for Sera conformity; components hand-edited per app, mixed Lucide/Tabler.
    After: every registry-backed component diffed against a fresh Sera scaffold by a read-only audit; stale items it found (drawer, slider, icons, web rounded-md) fixed.
  • Checks: bun run check, bun run typecheck (7/7), packages/ui tests (41), radio tests (3476 pass, 0 fail), radio and web builds.
  • Not verified: no before/after screenshots; slider, drawer and the swapped icons were not reviewed in the browser.

Merge Danger

Door: two-way

Blast Radius: app-wide visuals

Every screen loses its rounded corners, buttons become uppercase, inputs become underlined, and icons change shape (e.g. AudioLines/Waves both become IconWaveSine). Intentional Sera behavior changes: Select popups align the selected item with the trigger, context menus open to the right with no offset, inputs and textareas show focus as an underline colour change, textareas do not resize, and buttons keep their full padding next to an icon until icons carry data-icon. Everything else the regeneration dropped was restored in 0078bb2. Stacked on dev-design (#459).

az3ta and others added 3 commits November 1, 2026 16:01
Regenerate the shared UI components from the base-sera registry (button, card,
input, textarea, alert, skeleton, spinner, separator, collapsible, scroll-area,
resizable, toggle-group, field, empty, tabs, dialog, popover, select, menus,
accordion, badge, sonner) and import shadcn/tailwind.css with the Sera radius
scale. Keep the local behaviour on top: toast-layer guards on dialog and
popover, menu return focus, the select xs size, the toast re-export and
ResizablePanelHandle. Checkbox, switch, radio-group, toggle, label, tooltip,
slider and the vaul drawer keep their current source, which already matches
Sera or carries local fixes.

Replace arbitrary values with tokens where Tailwind has one (ring-3,
text-caption, -bottom-1.25, w-25, hover:bg-secondary/80).

Changelog: skip

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Changelog: skip

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ck transport

Changelog: skip

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 510bae53-6530-43e0-a328-a19f349fde45

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-03T17:19:27.894827Z
We couldn’t complete this review. Comment @codex review to try again.
7295b0f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Failed ❌

View logs ↗
53fc5fc 2026-11-01T18:44:17.683Z View logs ↗

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Failed ❌

View logs ↗
7295b0f 2026-11-03T17:20:56.426Z View logs ↗
  • Build: Failed ❌

View logs ↗
0078bb2 2026-11-02T07:51:06.760Z View logs ↗
  • Build: Failed ❌

View logs ↗
53fc5fc 2026-11-01T18:44:41.702Z View logs ↗

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 53fc5fc9d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 18 to 20
data-orientation={orientation}
data-slot="tabs"
orientation={orientation}
{...props}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Forward the orientation prop to the tabs primitive

On desktop, SettingsForm passes orientation="vertical" so its column of settings sections can be navigated with Up/Down. This wrapper now consumes that prop without passing it to TabsPrimitive.Root; setting data-orientation only affects styling, so Base UI retains its horizontal keyboard behavior and accessibility orientation. Restore orientation={orientation} on the primitive so keyboard navigation matches the displayed section list.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0078bb2. orientation is passed to the primitive again.

>
<ScrollAreaPrimitive.Viewport
className="size-full max-h-[inherit] rounded-[inherit] outline-none transition-[color,box-shadow] focus-visible:outline-1 focus-visible:ring-[3px] focus-visible:ring-ring/50"
className="size-full rounded-[inherit] outline-none transition-[color,box-shadow] focus-visible:outline-1 focus-visible:ring-3 focus-visible:ring-ring/50"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the scroll viewport constrained by the root's maximum height

When station search returns enough rows to exceed the dropdown height, RadioSearchBar relies on <ScrollArea className="max-h-72 overflow-hidden">. Removing max-h-[inherit] from the viewport leaves it with only a percentage height inside a root without a definite height, allowing it to grow with its contents instead of becoming scrollable. The root then clips the remaining results. RadioGardenTab similarly uses only max-h-[50vh]. Preserve the inherited maximum height on the viewport so these existing callers can scroll through all results.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0078bb2. The viewport has max-h-[inherit] and the root overflow-hidden again.

Comment thread packages/ui/src/components/dialog.tsx Outdated
<DialogPrimitive.Popup
className={cn(
"data-open:fade-in-0 data-open:zoom-in-95 data-closed:fade-out-0 data-closed:zoom-out-95 fixed top-1/2 left-1/2 z-50 flex max-h-[90vh] w-full max-w-[calc(100%-2rem)] -translate-x-1/2 -translate-y-1/2 flex-col gap-6 rounded-none bg-popover p-6 text-popover-foreground text-sm shadow-md outline-none ring-1 ring-foreground/10 duration-100 data-closed:animate-out data-open:animate-in sm:max-w-md",
"data-open:fade-in-0 data-open:zoom-in-95 data-closed:fade-out-0 data-closed:zoom-out-95 fixed top-1/2 left-1/2 z-50 grid w-full max-w-[calc(100%-2rem)] -translate-x-1/2 -translate-y-1/2 gap-6 rounded-none bg-popover p-6 text-popover-foreground text-sm shadow-md outline-none ring-1 ring-foreground/10 duration-100 data-closed:animate-out data-open:animate-in sm:max-w-md",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the shared dialog's viewport-height limit

On short screens, the station-details dialog in radio-now-playing.tsx depends on the shared max-h-[90vh] limit: its content has overflow-y-auto, but its DialogContent supplies no height constraint of its own. Removing the shared maximum lets the centered, fixed popup grow taller than the viewport, placing its header and close control offscreen and preventing the body from scrolling within the dialog. Retain a viewport-relative maximum height so existing dialogs remain usable without every caller adding its own constraint.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0078bb2. The popup is a flex column capped at the viewport height again.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14 issues found across 131 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/ui/src/components/textarea.tsx">

<violation number="1" location="packages/ui/src/components/textarea.tsx:8">
P2: Keyboard focus on this textarea is now only a 1px bottom-border color change, and the light-mode `--ring` color is low contrast against the background. The removed 3px focus ring was a much more visible indicator. Keep a stronger focus indicator here, or confirm the underline treatment meets the focus-visibility bar.</violation>

<violation number="2" location="packages/ui/src/components/textarea.tsx:8">
P3: Adding `resize-none` to the shared Textarea removes manual vertical resizing from every textarea in both apps, which is a behavior change the PR says it does not make. Drop `resize-none` from the base classes and let `field-sizing-content` handle growth, or add it only where a consumer needs it.</violation>
</file>

<file name="packages/ui/src/components/field.tsx">

<violation number="1" location="packages/ui/src/components/field.tsx:136">
P2: `group-has-data-horizontal/field:text-balance` matches a `data-horizontal` attribute, but `Field` renders `data-orientation="horizontal"`. Horizontal descriptions will silently lose `text-balance`. Restore the original selector.</violation>
</file>

<file name="apps/radio/src/components/radio/radio-loading-skeleton.tsx">

<violation number="1" location="apps/radio/src/components/radio/radio-loading-skeleton.tsx:176">
P3: These circular placeholders lost `rounded-full`, so they now render as squares. The real play-pause button and knob are still round, so the loading state no longer matches the loaded UI. Restore `rounded-full` on the circular placeholders that mirror those controls, or drop the corner removal for them.</violation>
</file>

<file name="packages/ui/src/components/input.tsx">

<violation number="1" location="packages/ui/src/components/input.tsx:9">
P2: Focus and invalid states on Input now rely only on a 1px bottom border color change. That is a weaker indicator than the 3px ring used before and than the ring-based focus used by the other controls here. Consider keeping a visible focus indicator, such as a thicker bottom border or a ring, so keyboard focus and `aria-invalid` remain clearly visible.</violation>
</file>

<file name="packages/ui/src/components/card.tsx">

<violation number="1" location="packages/ui/src/components/card.tsx:12">
P2: `overflow-hidden` on `Card` clips focus rings and box-shadows of children that reach the card edge. Consider dropping it, or clipping only the image children with `*:[img]:...` selectors.</violation>
</file>

<file name="packages/ui/src/components/button.tsx">

<violation number="1" location="packages/ui/src/components/button.tsx:23">
P3: The `has-data-[icon=...]` padding rules only apply when callers add `data-icon` to their icons, and no call site does. Icon-plus-label buttons will use the full label padding; either add `data-icon` to icons or keep an svg-based selector.</violation>
</file>

<file name="packages/ui/src/components/slider.tsx">

<violation number="1" location="packages/ui/src/components/slider.tsx:115">
P2: The default slider shrinks sharply: a 2px track with a 12px square thumb, and the track now uses the faint `bg-input/50`. The effect-parameter and channel sliders use this variant, so they may become hard to see and grab. Keep the track at `h-1.5`/`w-1.5` (or verify visually) before merging.</violation>
</file>

<file name="packages/ui/src/components/dialog.tsx">

<violation number="1" location="packages/ui/src/components/dialog.tsx:110">
P1: Removing `max-h-[90vh]` leaves the shared dialog popup unbounded. The now-playing details dialog in `radio-now-playing.tsx` depends on that cap for its inner scroll region, so on short viewports its header and bottom content get clipped and cannot be scrolled to. Restore `max-h-[90vh]` with the previous flex-column layout, or constrain the body row if the grid layout is kept.</violation>
</file>

<file name="packages/ui/src/components/context-menu.tsx">

<violation number="1" location="packages/ui/src/components/context-menu.tsx:33">
P2: The new `ContextMenuContent` defaults change where every context menu opens: `side` is now "right" with `sideOffset` 0, where it was the Base UI default with a 4px offset. Restore the pre-PR placement defaults, or call out the placement change in the PR description since the PR says no behavior changes are intended.</violation>
</file>

<file name="packages/ui/src/components/select.tsx">

<violation number="1" location="packages/ui/src/components/select.tsx:70">
P2: Flipping `alignItemWithTrigger` to `true` changes popup placement for every Select, so the selected item overlays the trigger. It also enables `animate-none` for all popups. This is not in the PR's stated no-behavior-change scope and is not called out in the description. Keep the previous `false` default unless this change was reviewed deliberately.</violation>
</file>

<file name="apps/radio/src/components/radio/node/output-device-content.tsx">

<violation number="1" location="apps/radio/src/components/radio/node/output-device-content.tsx:141">
P2: The output mute button uses `IconVolume3` when `data.muted`, which is a volume-level icon rather than a muted/off icon. Use `IconVolumeOff` for muted and `IconVolume2` for the existing non-muted state.</violation>
</file>

<file name="packages/ui/src/components/dropdown-menu.tsx">

<violation number="1" location="packages/ui/src/components/dropdown-menu.tsx:44">
P2: Dropdown-menu wrappers no longer evaluate Base UI stateful `className` callbacks, so custom open, disabled, or highlighted styling can disappear. Preserve the callback form and call `className(state)` before merging classes.</violation>
</file>

<file name="packages/ui/src/components/toggle-group.tsx">

<violation number="1" location="packages/ui/src/components/toggle-group.tsx:46">
P3: A caller-supplied `style` now overwrites ToggleGroup’s generated `--gap`, disabling spacing. Destructure `style` and merge it with the generated CSS variable before spreading the remaining props.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread packages/ui/src/components/dialog.tsx Outdated
<DialogPrimitive.Popup
className={cn(
"data-open:fade-in-0 data-open:zoom-in-95 data-closed:fade-out-0 data-closed:zoom-out-95 fixed top-1/2 left-1/2 z-50 flex max-h-[90vh] w-full max-w-[calc(100%-2rem)] -translate-x-1/2 -translate-y-1/2 flex-col gap-6 rounded-none bg-popover p-6 text-popover-foreground text-sm shadow-md outline-none ring-1 ring-foreground/10 duration-100 data-closed:animate-out data-open:animate-in sm:max-w-md",
"data-open:fade-in-0 data-open:zoom-in-95 data-closed:fade-out-0 data-closed:zoom-out-95 fixed top-1/2 left-1/2 z-50 grid w-full max-w-[calc(100%-2rem)] -translate-x-1/2 -translate-y-1/2 gap-6 rounded-none bg-popover p-6 text-popover-foreground text-sm shadow-md outline-none ring-1 ring-foreground/10 duration-100 data-closed:animate-out data-open:animate-in sm:max-w-md",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Removing max-h-[90vh] leaves the shared dialog popup unbounded. The now-playing details dialog in radio-now-playing.tsx depends on that cap for its inner scroll region, so on short viewports its header and bottom content get clipped and cannot be scrolled to. Restore max-h-[90vh] with the previous flex-column layout, or constrain the body row if the grid layout is kept.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/ui/src/components/dialog.tsx, line 110:

<comment>Removing `max-h-[90vh]` leaves the shared dialog popup unbounded. The now-playing details dialog in `radio-now-playing.tsx` depends on that cap for its inner scroll region, so on short viewports its header and bottom content get clipped and cannot be scrolled to. Restore `max-h-[90vh]` with the previous flex-column layout, or constrain the body row if the grid layout is kept.</comment>

<file context>
@@ -111,11 +103,11 @@ function DialogContent({
+      <DialogPrimitive.Popup
         className={cn(
-          "data-open:fade-in-0 data-open:zoom-in-95 data-closed:fade-out-0 data-closed:zoom-out-95 fixed top-1/2 left-1/2 z-50 flex max-h-[90vh] w-full max-w-[calc(100%-2rem)] -translate-x-1/2 -translate-y-1/2 flex-col gap-6 rounded-none bg-popover p-6 text-popover-foreground text-sm shadow-md outline-none ring-1 ring-foreground/10 duration-100 data-closed:animate-out data-open:animate-in sm:max-w-md",
+          "data-open:fade-in-0 data-open:zoom-in-95 data-closed:fade-out-0 data-closed:zoom-out-95 fixed top-1/2 left-1/2 z-50 grid w-full max-w-[calc(100%-2rem)] -translate-x-1/2 -translate-y-1/2 gap-6 rounded-none bg-popover p-6 text-popover-foreground text-sm shadow-md outline-none ring-1 ring-foreground/10 duration-100 data-closed:animate-out data-open:animate-in sm:max-w-md",
           className
         )}
</file context>
Suggested change
"data-open:fade-in-0 data-open:zoom-in-95 data-closed:fade-out-0 data-closed:zoom-out-95 fixed top-1/2 left-1/2 z-50 grid w-full max-w-[calc(100%-2rem)] -translate-x-1/2 -translate-y-1/2 gap-6 rounded-none bg-popover p-6 text-popover-foreground text-sm shadow-md outline-none ring-1 ring-foreground/10 duration-100 data-closed:animate-out data-open:animate-in sm:max-w-md",
"data-open:fade-in-0 data-open:zoom-in-95 data-closed:fade-out-0 data-closed:zoom-out-95 fixed top-1/2 left-1/2 z-50 flex max-h-[90vh] w-full max-w-[calc(100%-2rem)] -translate-x-1/2 -translate-y-1/2 flex-col gap-6 rounded-none bg-popover p-6 text-popover-foreground text-sm shadow-md outline-none ring-1 ring-foreground/10 duration-100 data-closed:animate-out data-open:animate-in sm:max-w-md",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0078bb2. Viewport cap and flex column restored.

Comment thread packages/ui/package.json Resolved
Comment thread packages/ui/src/components/badge.tsx Resolved
},
size: {
default:
"h-10 gap-1.5 px-6 has-data-[icon=inline-end]:pr-4 has-data-[icon=inline-start]:pl-4",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The has-data-[icon=...] padding rules only apply when callers add data-icon to their icons, and no call site does. Icon-plus-label buttons will use the full label padding; either add data-icon to icons or keep an svg-based selector.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/ui/src/components/button.tsx, line 23:

<comment>The `has-data-[icon=...]` padding rules only apply when callers add `data-icon` to their icons, and no call site does. Icon-plus-label buttons will use the full label padding; either add `data-icon` to icons or keep an svg-based selector.</comment>

<file context>
@@ -1,58 +1,55 @@
+      },
+      size: {
+        default:
+          "h-10 gap-1.5 px-6 has-data-[icon=inline-end]:pr-4 has-data-[icon=inline-start]:pl-4",
+        xs: "h-7 gap-1 px-3 has-data-[icon=inline-end]:pr-2 has-data-[icon=inline-start]:pl-2 [&_svg:not([class*='size-'])]:size-3",
+        sm: "h-9 gap-1 px-4 has-data-[icon=inline-end]:pr-3 has-data-[icon=inline-start]:pl-3",
</file context>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up: Sera pads icon buttons via data-icon, and no call site sets it yet. Listed in the PR description; adding data-icon across the apps is a separate change.

Comment thread packages/ui/src/components/field.tsx Resolved
data-variant={variant}
orientation={orientation}
style={{ "--gap": spacing, ...style } as CSSProperties}
style={{ "--gap": spacing } as CSSProperties}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: A caller-supplied style now overwrites ToggleGroup’s generated --gap, disabling spacing. Destructure style and merge it with the generated CSS variable before spreading the remaining props.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/ui/src/components/toggle-group.tsx, line 46:

<comment>A caller-supplied `style` now overwrites ToggleGroup’s generated `--gap`, disabling spacing. Destructure `style` and merge it with the generated CSS variable before spreading the remaining props.</comment>

<file context>
@@ -19,35 +19,31 @@ const ToggleGroupContext = createContext<
       data-variant={variant}
-      orientation={orientation}
-      style={{ "--gap": spacing, ...style } as CSSProperties}
+      style={{ "--gap": spacing } as CSSProperties}
       {...props}
     >
</file context>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0078bb2. Caller style is merged with --gap.

@az3ta az3ta changed the title Reset UI to shadcn Sera and swap Lucide for Tabler style: reset UI to shadcn Sera and swap Lucide for Tabler Nov 1, 2026
az3ta and others added 2 commits November 2, 2026 08:49
Restores tabs orientation and activateOnFocus, scroll-area max height and
content wrapper, dialog height cap, toggle-group pressed state and style
merge, collapsible and accordion height transitions, separator decorative
role, dropdown closeOnClick, select list labels and wrapping, popover
positioning props, field error trim, muted volume icon, and moves shadcn to
dependencies so builds can resolve its CSS. The changelog test now fakes
animation frames so it passes on its own.

Changelog: skip

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Darkens the light destructive colour for 4.5:1 contrast, restores the
disabled accordion opacity, context-menu closeOnClick and the open submenu
highlight.

Changelog: skip

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@az3ta
az3ta merged commit a0dae27 into dev-design Nov 3, 2026
2 of 4 checks passed
@az3ta
az3ta deleted the chore/ui-sera-reset branch November 3, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant