Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/radio/scripts/check-node-chunk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ for (const [name, source] of flowChunks) {
}

// The canvas is Node mode's only door to React Flow: the chunk that lazily
// loads it also draws the Stage, Rack and inspector, which a phone opens
// first, so it must not reach React Flow through static imports.
// loads it also draws the Rack and inspector, which load without React
// Flow, so it must not reach React Flow through static imports.
const canvasChunks = [...chunks.keys()].filter(
(name) =>
name.startsWith("node-canvas-") || name.startsWith("immutable-node-canvas-")
Expand Down
9 changes: 5 additions & 4 deletions apps/radio/src/components/radio/NODE_MODE_PROPOSAL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Node Mode v1

Node Mode replaces Multiple with a React Flow patch editor, Stage and Rack over
Node Mode replaces Multiple with a React Flow patch editor and a desktop Rack over
radio's managed playback engine. This is the current implementation contract for
agents changing Node Mode. The product release is **v1**; its persisted graph
schema is **version 2**, which added source strips. Schema versions and the
Expand Down Expand Up @@ -142,8 +142,9 @@ release; insertion and cable surgery commit one undoable graph change. Cancellin
or pinching a drag clears its insertion target. Removing a Merge is refused when
healing would break a working lane's routes.

Stage and Rack provide source controls outside the zoomed canvas. Rack also lists
loose, empty or invalid modules and shows graph issues when no lane compiles.
On desktop, the Rack provides source controls outside the zoomed canvas. It also lists
loose, empty or invalid modules and shows graph issues when no lane compiles. A phone
shows the canvas alone.
Inspect opens shared source, device, native, FX or output settings; desktop Inspect
expands a collapsed Rack panel and phones use the inspector drawer. Local files
that cannot survive reload expose Pick again.
Expand Down Expand Up @@ -175,7 +176,7 @@ throttled graph or engine writes.
| Persistence, migration and local NAM retention | [`playback-sessions.ts`](../../lib/collections/playback-sessions.ts), [`migrations/`](../../lib/collections/migrations/) |
| Backup validation, preview and application | [`export-import.ts`](../../lib/db/export-import.ts), [`nam-backup.ts`](../../lib/db/nam-backup.ts) |
| Canvas, palette and cable editing | [`node-canvas.tsx`](node/node-canvas.tsx), [`node-palette.tsx`](node/node-palette.tsx), [`connect-dialog.tsx`](node/connect-dialog.tsx), [`rewire-dialog.tsx`](node/rewire-dialog.tsx) |
| Stage, Rack, inspector and shared source forms | [`node-stage.tsx`](node/node-stage.tsx), [`node-rack.tsx`](node/node-rack.tsx), [`node-inspector.tsx`](node/node-inspector.tsx); source/device `*-content.tsx` files beside them |
| Rack, inspector and shared source forms | [`node-rack.tsx`](node/node-rack.tsx), [`node-inspector.tsx`](node/node-inspector.tsx); source/device `*-content.tsx` files beside them |
| Shared knobs, sliders and control gestures | [`knob.tsx`](../../../../../packages/ui/src/components/knob.tsx), [`slider.tsx`](../../../../../packages/ui/src/components/slider.tsx) |
| Node MIDI identities and actions | [`node-midi-actions.ts`](../../lib/midi/node-midi-actions.ts), [`use-node-midi.ts`](../../lib/hooks/use-node-midi.ts) |

Expand Down
4 changes: 2 additions & 2 deletions apps/radio/src/components/radio/node/audio-input-controls.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ import type { NodeDevice } from "./use-node-devices";
/**
* Audio Input Controls
*
* The pieces an Audio input shows on the canvas and in the Stage and Rack,
* The pieces an Audio input shows on the canvas and in the Rack,
* in DJ's words: Go live and Pause input, Paused and Live, the device and its
* channels. None of them import React Flow, so the Stage and Rack can load
* channels. None of them import React Flow, so the Rack can load
* them without the canvas chunk.
*/

Expand Down
2 changes: 1 addition & 1 deletion apps/radio/src/components/radio/node/branch-edge.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { keepControlKeys } from "./module-frame";
* carries that branch's gain, pan, mute and solo. It draws as a plain wire
* with a small tag at its middle ("2", "L", "Mid", plus what is set), and
* the tag opens the branch's controls. The inspector lists the same
* controls for every branch, so a phone reaches them from the Rack.
* controls for every branch, so a phone reaches them from its drawer.
*/

export type BranchFlowEdge = FlowEdge<BranchEdgeData, "branch">;
Expand Down
2 changes: 1 addition & 1 deletion apps/radio/src/components/radio/node/cable-surgery.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* or else a node picked from the palette;
* - Cmd+D (Ctrl+D elsewhere) duplicates the selected nodes.
* Keys act from the canvas or with nothing focused, never from a field, a
* dialog, the Stage or the Rack. Lives outside the canvas chunk's React
* dialog, the Rack or the inspector. Lives outside the canvas chunk's React
* Flow imports, so it is testable without them.
*/

Expand Down
2 changes: 1 addition & 1 deletion apps/radio/src/components/radio/node/device-nodes.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ describe("Audio input node", () => {
expect(onEchoCancellationChange.mock.calls[0]?.[0]).toBe(true);
});

test("the Stage row pauses a live input whose device is unplugged", async () => {
test("the Rack row pauses a live input whose device is unplugged", async () => {
media.permission = "granted";
const controls = {
setPlaying: mock(async (_nodeId: string, _playing: boolean) => undefined),
Expand Down
9 changes: 7 additions & 2 deletions apps/radio/src/components/radio/node/docs/acceptance.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,22 @@ rows explicitly identify DOM events injected into the running app.
| Desktop inspector | **Passed:** empty Station search, File picker/URL tabs, Output device selection and Gate parameters opened from Rack. |
| Collapsed desktop Rack | **Passed:** separator End collapsed the panel to 0px; Gate → All settings expanded it to 240px and exposed parameters. |
| Desktop Rewire and Undo | **Passed:** keyboard selected Output device as the Station cable destination. Apply preserved cable identity, gain and mute; one Undo restored Speakers. |
| Phone layout and inspector | **Passed in Chromium viewport:** Stage/Rack/Patch accessible; Rack opened the Audio input drawer. Drawer showed Off and the browser's blocked-microphone message. No document-level horizontal overflow. |
| Phone layout and inspector | **Passed in Chromium viewport:** the canvas was accessible; Inspect opened the Audio input drawer. Drawer showed Off and the browser's blocked-microphone message. No document-level horizontal overflow. |
| Phone Rewire | **Passed in Chromium viewport:** focused cable selected with Enter; toolbar opened a 358px dialog inside the 390px viewport. Keyboard destination selection and Apply stored the correct route. |
| Knob keyboard accumulation | **Passed:** five ArrowUp presses moved Gate threshold from −6 to −3.5; five synthetic key events before a render reached the same stored value. |
| Knob reset | **Passed with synthetic events:** double-click and Ctrl+primary pointer-down restored Gate threshold to −6 in both UI and stored graph. |
| Knob fine wheel | **Passed with synthetic wheel:** one upward event changed threshold from −6 to −5.99 and persisted it. |
| Slider fine wheel and reset | **Passed with synthetic events:** phone Stage master slider moved from 0.99 to 0.98 for one downward wheel event; Ctrl+primary reset UI and stored master volume to 1. |
| Slider fine wheel and reset | **Passed with synthetic events:** phone master slider moved from 0.99 to 0.98 for one downward wheel event; Ctrl+primary reset UI and stored master volume to 1. |

The local feedback availability request returned HTTP 502. It did not prevent
these Node interactions. No audio playback, permission grant or hardware routing
success is inferred from this run.

The phone rows above were recorded when a phone reached Node through separate
views. A phone now opens Node on the canvas alone, with settings in the
inspector drawer. The drawer and master controls those rows exercised are
unchanged, but the rows were not re-run.

## Recorded modulation checks

Checked on 2026-10-07 in T3 Code's collaborative preview with Chromium
Expand Down
Loading
Loading