Repository navigation
Cover Node Alhara RadioJar remount for RADIO-1Z - #474
Merged
Merged
Conversation
Prove the shared #456 toPlaybackInput rewrite already remounts persisted RadioJar Alhara URLs on the Node AudioManager play path, and that a real unsupported-stream failure still surfaces as a Node PLAY_ERROR. Fixes RADIO-1Z Changelog: skip Co-authored-by: Francesco Castrovilli <fcastrovilli@users.noreply.github.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://cursor-radio-1z-node-alhara-regression-7043-radio.cwav.workers.dev (commit 9a40b58)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Fixes RADIO-1Z
https://avoidquest.sentry.io/issues/RADIO-1Z
Root cause (verified): the only queryable production event (
2026-10-19,radio@0.7.1,mode=node, Chrome desktop) isPLAY_ERROR/Audio stream format is not supportedfrommediaElementErrorwhen the media readiness path attached the retired Radio Alhara RadioJar mountn03.radiojar.com(HTTP 404 today; first-party Alhara GET returns200audio/mpeg). Sentry’s culprit chunk name (mode-lifecycle-cleanup) is the Vite bundle that includes that readiness callback, not a separate Node dispose bug.Issue activity: first seen
2026-10-07, resolved inradio@0.7.1on2026-10-10, then regressed on2026-10-19with the RadioJar event. Tag distributions today only retain that RadioJar/node/0.7.1event.Already on main:
#456(f0c5c33) rewrites persisted RadioJar URLs in sharedtoPlaybackInput, whichAudioManager.playSounduses for Node lanes. No independent production change is needed for RADIO-1Z.This PR: test-only Node coverage so the remount cannot regress on the Node play path, and so a genuine unsupported-stream failure still becomes a lane-local Node
PLAY_ERROR(diagnostics preserved; no swallowing).Overlap with RADIO-22 / PR #472
singlenodeMEDIA_ERR_SRC_NOT_SUPPORTED→PLAY_ERROR#456media-element-playback-source.test.ts,playback-action-errors.test.tsaudio-manager.test.ts(NodeplaySoundremount),node-playback.test.ts(lanePLAY_ERROR)Matching error text alone is not a duplicate fingerprint (
modediffers). This PR does not repeat #472’s single-mode media-source or reporter tests and does not change loaders.Evidence (red → green)
Without the Alhara override (temporary local removal of the
#456line):With the override restored (current main behavior):
Live probes (not fixtures): RadioJar mount →
404; first-party Alhara GET range →200audio/mpeg.Validation
bun test apps/radio/src/lib/audio/manager/audio-manager.test.ts -t "Node playSound remounts"— passbun test apps/radio/src/lib/node-playback.test.ts -t "reports an unsupported stream format as a Node PLAY_ERROR"— passbun test apps/radio/src/lib/audio/manager/audio-manager.test.ts— 42 passbun run check— passbun run typecheck— passapps/radiosuite, browser E2E, deployRemaining limitations
stream_hosttelemetry uses the stored radio URL, so legacy RadioJar hosts can still appear in tags after a successful rewrite.0.7.2; confirm deploy carries#456if any residual RadioJar reports appear.7f7ed3bf52672df71a5514591af0b3a866708d0b(mainat PR open).Summary by cubic
Adds Node test coverage for RADIO-1Z, where the retired Radio Alhara RadioJar mount produced a
PLAY_ERRORon the Node play path. The URL rewrite already shipped in#456; this PR is test-only and proves the Node remount works and that real unsupported-stream failures still surface as a lane-localPLAY_ERROR.Tests
AudioManager.playSoundremounts persisted Radio Alhara RadioJar URLs before readiness.PLAY_ERRORwith diagnostics intact, aligned with Node's unsupported-format guidance.Written for commit 9a40b58. Summary will update on new commits.