Repository navigation
test(radio): Lock YouTube provider outage failover for RADIO-25 - #477
Merged
fcastrovilli merged 1 commit intoNov 7, 2026
Merged
Conversation
Add synthetic regressions for the Oct 29 radio@0.7.2 DJ resolution event: HTTP 500 and fetch/CORS failures across the curated pool, aggregate diagnostics, loader mapping, intentional unexpected reporting, and DJ refresh onFailed handling. No production change: failover and reporting already match the intended contract for volunteer relay outages. Co-authored-by: Francesco Castrovilli <fcastrovilli@users.noreply.github.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://cursor-radio-25-youtube-provider-resolution-5bf8-radio.cwav.workers.dev (commit f0b9e59)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
fcastrovilli
deleted the
cursor/radio-25-youtube-provider-resolution-5bf8
branch
November 7, 2026 23:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigation of RADIO-25 (
YouTubeProviderAggregateError/YOUTUBE_CLIENT_RESOLUTION_FAILED, productionradio@0.7.2, Chrome desktop,mode=dj, 2026-10-29).Verified cause: every curated browser YouTube relay failed (HTTP 500 and network/CORS /
Failed to fetch). Failover walked the pool, aggregated retryable provider errors, surfacedEvery configured YouTube provider failedto the DJ pick UI, and reported the failure to Sentry as unexpected playback telemetry. That matches the intentional contract for volunteer Piped/Invidious outages; no app defect was shown that would justify a production change orFixes RADIO-25.What changed
Regression coverage only (synthetic mocked fetch/provider responses; no raw event URLs, PII, or secrets):
packages/platforms/src/youtube/provider.test.ts— HTTP 500 + network/CORS failover, aggregate diagnostics, recovery when a later provider succeedsapps/radio/src/lib/youtube/client.test.ts— curatedresolveItempool exhaustion matching the event shapeapps/radio/src/lib/platform-item-loader.test.ts— loader keepsYOUTUBE_CLIENT_RESOLUTION_FAILED+ aggregate cause for UI/reportingpackages/error/src/index.test.ts— pool exhaustion stayserror_expected=false(ops visibility; not silenced)apps/radio/src/lib/platform-stream-refresh.test.ts— YouTube refresh throws go throughonFailedwithDJ_YOUTUBE_REFRESH_FAILEDrequest metadataEvidence (red/green)
No failing production-path assertion was found before adding these locks; the new regressions are green against current
mainand document the intended behavior rather than driving a manufactured silence of unexpected errors.Commands:
Base SHA:
7f7ed3bf52672df71a5514591af0b3a866708d0b(origin/main)Limits / caveats
expected: truewas rejected: existing reporting policy and tests treatYOUTUBE_CLIENT_RESOLUTION_FAILEDas unexpected so curated-pool outages remain visible in Sentry.onFailed; deck reporting currently defaults that path toPLAY_ERRORrather than the request’sDJ_YOUTUBE_REFRESH_FAILEDcode. That asymmetry is out of scope for this issue’s initial-resolution stack and was not changed.Sentry
Issue: https://avoidquest.sentry.io/issues/RADIO-25
No
Fixes RADIO-25— root defect not fixed because none was demonstrated in application code.Summary by cubic
Adds regression tests that lock in the YouTube provider failover behavior behind RADIO-25. No production code changes; the new tests confirm the existing contract: pooled HTTP 500 and network/CORS failures aggregate into
YouTubeProviderAggregateErrorand surface asYOUTUBE_CLIENT_RESOLUTION_FAILED, while recovery when a later provider succeeds still works.onFailed, anderror_expected=falsereporting.onFailedbut deck reporting maps it toPLAY_ERROR(unchanged).Written for commit f0b9e59. Summary will update on new commits.