Skip to content

Make timetable checks quiet when no mirror is configured - #27

Merged
fcastrovilli merged 1 commit into
mainfrom
fix/no-mirror-checks
Nov 2, 2026
Merged

fcastrovilli merged 1 commit into
mainfrom
fix/no-mirror-checks

Conversation

@fcastrovilli

@fcastrovilli fcastrovilli commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

 transit-data/service.ts  check()
+  if no mirror configured → 'unsupported' (no request, no failure, no backoff)
 transit-data/refresh-policy.ts  scheduleNotices()
+  skip "Orari non confermati da GTT da oltre 48 ore" when updatesConfigured === false
 StopBoardPanel
+  unsupported → "Orari dal pacchetto incluso nell'app: si aggiornano con le nuove versioni. …"

Follow-up to #23 (empty TIMETABLE_MIRRORS), raised by CodeRabbit on #25: every manifest check failed with "Nessun server orari configurato" and backed off, and boards would show a permanent unconfirmed warning 48 hours after install — misleading during the field test. The provenance line still shows the bundled feed version and date; "Aggiorna orari" still refreshes the GTT identity remap.

Evidence

  • Before: check('manual') → failed, backoff recorded; scheduleNotices(…, +49 h) → schedule-unconfirmed.
    After: new tests: no-mirror check → unsupported, zero requests, no failure/error; no-mirror notices at +49 h → none (with a mirror → schedule-unconfirmed, unchanged).
  • bun run verify: typecheck, zero-warning lint, 503 tests.

Merge Danger

Door: two-way

Blast Radius: transit-data

Optional timetable refresh status and one board notice.


Summary by cubic

Makes timetable checks quiet when no mirror is configured, so an empty TIMETABLE_MIRRORS no longer produces failed checks, backoff, or a permanent "unconfirmed" warning on boards.

  • Mirrorless checks now return unsupported without making a request or recording a failure.
  • The 48-hour "Orari non confermati" notice is suppressed when updates are unavailable; the provenance line still shows the bundled feed version and date.
  • "Aggiorna orari" still refreshes the GTT identity remap, and board UI shows a message explaining that timetable data ships with app updates.

Written for commit c4a95ca. Summary will update on new commits.

View guided diff Turn on auto-fix

With an empty mirror list every manifest check failed with 'Nessun server
orari configurato', backed off, and boards would show a permanent
'non confermati da 48 ore' warning two days after install. Checks now
return 'unsupported' without a request, failure or backoff, and the
unconfirmed warning is shown only when a mirror could confirm the package.
Aggiorna orari still refreshes the GTT identity remap.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T01:45:40.649880Z c4a95ca PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5a6d91ae-16f4-4123-9f85-a983c6d09302
Commits

Reviewing files that changed from the base of the PR and between 5fd50f3 and c4a95ca.

Files selected for processing: 7
  • docs/development/data.md
  • src/features/transit/StopBoardPanel.tsx
  • src/services/transit.ts
  • src/transit-data/board.ts
  • src/transit-data/refresh-policy.ts
  • src/transit-data/service.test.ts
  • src/transit-data/service.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@fcastrovilli
fcastrovilli merged commit d67b606 into main Nov 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant