Repository navigation
Make timetable checks quiet when no mirror is configured - #27
Merged
Merged
Conversation
With an empty mirror list every manifest check failed with 'Nessun server orari configurato', backed off, and boards would show a permanent 'non confermati da 48 ore' warning two days after install. Checks now return 'unsupported' without a request, failure or backoff, and the unconfirmed warning is shown only when a mirror could confirm the package. Aggiorna orari still refreshes the GTT identity remap.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #23 (empty
TIMETABLE_MIRRORS), raised by CodeRabbit on #25: every manifest check failed with "Nessun server orari configurato" and backed off, and boards would show a permanent unconfirmed warning 48 hours after install — misleading during the field test. The provenance line still shows the bundled feed version and date; "Aggiorna orari" still refreshes the GTT identity remap.Evidence
check('manual')→failed, backoff recorded;scheduleNotices(…, +49 h)→schedule-unconfirmed.After: new tests: no-mirror check →
unsupported, zero requests, no failure/error; no-mirror notices at +49 h → none (with a mirror →schedule-unconfirmed, unchanged).bun run verify: typecheck, zero-warning lint, 503 tests.Merge Danger
Door: two-way
Blast Radius: transit-data
Optional timetable refresh status and one board notice.
Summary by cubic
Makes timetable checks quiet when no mirror is configured, so an empty
TIMETABLE_MIRRORSno longer produces failed checks, backoff, or a permanent "unconfirmed" warning on boards.unsupportedwithout making a request or recording a failure.Written for commit c4a95ca. Summary will update on new commits.