perf: stop cache localNode invalidate bubble (sticky cacheAsBitmap) - #7
Open
roncarbot wants to merge 1 commit into
Open
perf: stop cache localNode invalidate bubble (sticky cacheAsBitmap)#7roncarbot wants to merge 1 commit into
roncarbot wants to merge 1 commit into
Conversation
Do not bubble ContainerNode.invalidate into transformDisabled parents (cache RTT space). Skip SCENE_TRANSFORM-only invalidate on localNode. Mark ancestor CacheRenderers dirty on add/remove and real child moves. Fixes Diggy parent-cache dirty-every-frame loop (E8).
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContainerNode.invalidate()intotransformDisabledparents (cache RTT /localNode).localNode.Fixes Diggy whole-title
cacheAsBitmaprebuilding the RTT every frame (hold-frame timeline mtx → child SCENE_TRANSFORM → localNode → CacheRenderer). Pairs with awayjs/renderer#35 and awayjs/scene render-perf.Test plan
Diggy gameplay unlock (2026-09-09)
Unlocked via
localhost.coolmathgames.com; in-level median 50 ms, ~254 draws, cacheRenders=0 (GroundFG LAYER/ERASE not → renderToImage yet). Title kids cache still 16.7 ms. See renderer#35.E10 (no new view commit)
Diggy menu l1–l7 sticky cache validated on coolmath host: 100→16.7 ms, 370→~53 draws,
cacheRenders=0(parallax transform-only).