Repository navigation
fix(web-ui): translate the deck list load error and test Settings - #496
Merged
Merged
Conversation
- useDeckList: the first-load failure banner shows the translated decksPage.errorLoadDecks instead of the raw deckService error (English); the raw error goes to console.error. Translated at render, so the load effect does not re-run on locale change. - Add Settings.test.tsx (local): the agent-updated toast is translated (ja) and a failed PUT rolls the selection back with the translated error. Follow-up to review items 3 and 5 of #493. Verified: i18n key parity OK; eslint --quiet, tsc --noEmit pass; npm test 71 files pass; npm run build:cloud pass.
ShotaroKataoka
enabled auto-merge (squash)
November 2, 2026 23:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#493（refactor E）のレビューで残った低優先度の指摘 2 件（項目 3 と 5）への対応です。
変更
web-ui/src/hooks/useDeckList.ts）Failed to list decks: 500など）や英語のフォールバックではなく、decksPage.errorLoadDecksを表示します。Failed to load decks.デッキを読み込めませんでしたconsole.errorに残します（.kiro/steering/i18n.mdに沿い、エラー本文自体は翻訳しません）。tを足していないので、言語を切り替えても一覧を取り直しません。戻り値の形（error: string | null）は変わりません。web-ui/src/components/Settings.test.tsx、Local モード）useDeckList.test.tsに、読み込み失敗時のバナー文言（en / ja）のテストを追加しました。依存関係の変更はありません。
検証
.kiro/steering/i18n.md）: OKcd web-ui && npx eslint src/ --quiet && npx tsc --noEmit && npm test && npm run build:cloud: すべて pass（71 ファイル / 617 テスト）web-ui/next-env.d.tsは元に戻しています。