Conversation
simonkrol
force-pushed
the
github-pages-quick-start
branch
from
September 29, 2026 14:12
469b690 to
57e25f8
Compare
simonkrol
force-pushed
the
github-pages-quick-start
branch
from
September 29, 2026 14:37
57e25f8 to
69dd4a6
Compare
knihit
reviewed
Sep 29, 2026
knihit
left a comment
Contributor
There was a problem hiding this comment.
Posted comments for clarification.
simonkrol
force-pushed
the
github-pages-quick-start
branch
2 times, most recently
from
September 30, 2026 18:47
6733fc4 to
560fdbe
Compare
simonkrol
force-pushed
the
github-pages-quick-start
branch
3 times, most recently
from
September 30, 2026 21:40
71d563d to
9cec2d7
Compare
- Updated cli.rs's doc comment on the `--from` flag: it no longer claims installing from a published release is unavailable, and instead describes the real fallback chain (GitHub Release, then main's dist/ tarball) documented in cli/README.md. - Fixed install.rs's install summary on the no-`--from` remote path: it previously printed a false "skipped 0 SOP(s) (no runtime discovery path yet)" message even when SopInstallPhase had installed all 19 SOPs. Added a manifest-derived `sops` count (InstallCounts::sops / `sops_installed` in --json output) so the skip clause is now gated on `sops_skipped > 0`, leaving the --from path's existing skip wording untouched and reporting the real installed count on the no-`--from` path instead. - Updated cli/README.md's "Current limitations" bullet to match install.rs's corrected behavior.
…bundles Does not commit docs/site/USER_GUIDE_BUILD_NOTES.md: it is a per-run build log (see tools/build-user-guide/README.md's "Where things live", which describes it as generated output, not hand-authored content), and no prior commit in this repo's history ever included one -- the durable, previously committed build artifacts are .user-guide.manifest and user-guide.html. Added to .gitignore so it does not recur.
Hides init and metrics behind #[command(hide = true)] plus dispatch gating, matching the existing config pattern. Removes doctor's dormant config check from the live checks vector, matching the check_gitignore precedent. Fixes a stale remediation string in doctor.rs that recommended two now-hidden commands. Updates cli/README.md's command list, status blurb, check table, and Current-state section to match.
Bumps cli/konductor-rs's Cargo.toml/Cargo.lock (CLI binary version) and the top-level VERSION file (content version) from 1.0.3 to 1.0.4, paired with CHANGELOG.md's new [1.0.4] entry as required by validate-pr.yml's own VERSION-alongside-CHANGELOG gate. PR aws-solutions#20 (fix/telemetry-kiro-v2-v3), earlier expected not to merge, did merge and landed as the real, published 1.0.3 on main -- its own [1.0.3] CHANGELOG section (telemetry hook wiring, mcp/README.md drift) is real, permanent history now and is left untouched above this entry. This release's own version is 1.0.4, not a second claim on 1.0.3. The substantive work this release covers is already recorded in full in the "hide init/metrics, correct doctor's checks" and "withdraw init/metrics from the user guide" commits earlier in this branch; this commit is pure release bookkeeping layered on top of those.
Exclude SOP-derived sop-<name>/SKILL.md conversions from the skill count and report SOPs as a single, always-accurate N SOP(s) field/line instead of the prior 'skipped ... (no runtime discovery path yet)' wording, which was stale on every path this codebase now supports. Disambiguate SOP-derived conversions from hand-authored skills that happen to share the sop- filename prefix (e.g. skills/sop-state-management/) by detecting the <agent-sop name="..."> marker every SOP-conversion body carries, rather than relying on the sop- prefix alone, which produced a false positive that miscounted sop-state-management as SOP-derived.
The "all six checks above" line in the --all section predates every commit in this branch -- it was written at the 1.0.0 initial release and never updated when the check count changed to 8 (cli_version and content_version added outside run_checks(), telemetry_state renamed from an earlier removed check). git blame confirms no later commit touched these lines, so this is a standalone fix rather than a correction folded into any prior commit's history.
simonkrol
force-pushed
the
github-pages-quick-start
branch
2 times, most recently
from
October 1, 2026 20:18
bc695f1 to
6dc9652
Compare
simonkrol
marked this pull request as ready for review
October 1, 2026 20:19
simonkrol
requested review from
georgebearden,
ihmaws and
shsenior
as code owners
October 1, 2026 20:19
The `update` flag table in reference.md's flag reference never gained rows for --cli, --version <v>, and --force. All three trace to the initial v1.0.0 release (git log -S confirms each flag's introduction at 1f3f66c), predating every commit in this branch's range, and no later commit in this history ever added the missing rows -- reference.md has only ever been touched by 7223c96 (original authoring, outside this branch's range) and 359f7cc (command-table/config-section wording, leaving this flag table alone). tasks/update.md already documents all three flags in full (see its '--version <v> and --force' section and 'Update the CLI itself' section); this brings the flag reference table into sync with that existing, correct content.
simonkrol
force-pushed
the
github-pages-quick-start
branch
from
October 1, 2026 20:26
6dc9652 to
4e44696
Compare
Member
Author
|
Closing in favor of #31 as fork PRs don't run CodeQL checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI:
konductor initandkonductor metricsfrom--helpand gated them at dispatch behindKONDUCTOR_ALLOW_INIT=1/KONDUCTOR_ALLOW_METRICS=1— matches the existingkonductor configpattern exactly. Both are complete, tested commands withheld from the v1 customer-visible surface, not removed;metricsis additionally a genuine stub with no logic behind its gate.doctor'sconfigcheck from the live checks vector (run_checks) — matches the existingcheck_gitignoredormant-check precedent. Traced every consumer of the resolved config values and confirmed none acts on them for a real decision; the check was validating decorative output. Function and its unit tests stay intact, just not wired into live dispatch.doctornow runs 8 checks instead of 9.doctor's dormant config-load-failure remediation string (incheck_config_with_home, a check that is unit-tested but never called from live dispatch): it described a backup/hand-edit/delete-to-fallback recovery workflow forconfig.yml— the same stale "active risk" framing already removed from the docs. Since nothing reads or writes this file through any live command today, there's nothing to remediate against; the string now says so plainly instead of describing a workflow that doesn't apply to anything a user can currently do.cli.rs's--fromdoc comment, which claimed installing from a published release was unavailable — false since v1.0.0 shipped; now describes the real GitHub-release/main-dist fallback chain.--fromremote install path printing"skipped 0 SOP(s) (no runtime discovery path yet)"even when it had installed 19 real SOPs. Added a manifest-derived count so the message reports accurately on both the--fromand no---frompaths.install's SOP and skill counts: SOP-derivedsop-<name>/SKILL.mdconversions no longer count toward the skill total. Detection now looks for the<agent-sop name="...">marker every conversion carries, rather than thesop-filename prefix alone, which had misclassified a hand-authored skill (skills/sop-state-management/) that happened to share the prefix.cli/README.md's--allsection, which still said "all six checks above" after the live check count had already moved to 8updateflags (--cli,--version <v>,--force) toreference.md's flag table — present since the v1.0.0 release but never documented there;tasks/update.mdalready covered them in full.cli/README.mdbrought fully in line with all of the above: command list, status callout, check table, sample outputs, and "Current state" section.Docs:
docs/user-guide/quick-start.mdto lead with the curl-based quick install (fetches the published release) instead of framing source-building as the only path. Corrected a real misunderstanding baked into the prior draft — installing without--fromnever runssynthremotely, it fetchessynth's already-built output.docs/user-guide/tasks/update.mdso the no---fromcontent-update path (with--version,--force, doctor's new version-checks) leads, with--fromdemoted to a clearly labeled alternative for maintainers working from a local checkout.docs/user-guide/tasks/initialize-a-project.mdand removed every teaching reference toinit/metricsfromreference.md,concepts.md,glossary.md,faq.md— consistent with both being withdrawn from the documented command surface. Reworded every remediation step that used to recommend runninginitso it gives a manual alternative instead of a command that will now fail..konductor/config.yml's documentation inreference.md,notes.md, andtasks/update.md: it is not dead code — its load/validate logic is real and functional — but it is currently unreachable becauseconfig(the only command that reads or writes it) is hidden/gated the same wayinit/metricsare. Removed the "schema change might bite you" risk/recovery messaging entirely (back up your config, hand-edit it, re-scaffold it) since there is no live workflow where that risk currently applies; replaced with a flat statement that the file is not currently used.faq.md's "Is any of my data sent anywhere?" section, which claimed the CLI "touches the network in one place only:install" and that "neitherupdatenordoctormakes any release call" — both false.doctorfetches the latest release tag by default to check currency (skippable via--no-version-check); a no---fromupdatefetches a release by design;update --cliadditionally reaches the network for its self-replace step.synthremains the only command with zero network involvement, and is now stated as such specifically rather than folded into a blanket "everything else is local" claim.initialize-a-project.mddeletion (prev/next links, ToC entries, a mermaid diagram).prerequisites.md.docs/index.htmlanddocs/site/user-guide.htmlto match every markdown change above, via the deterministichtmlbundle.py/sync-html-content.pyedit mechanism — confirmed byte-identical to each other throughout, and independently verified by decoding both and diffing against current markdown content (not just the automated checker's narrower fact-based checks).Build tooling:
check-guide-facts.py's own withdrawn-command leak detector: its pattern required a trailing space that a JSON-quoted string value never has, lettingmetricsleak into both live HTML bundles undetected. Fixed the boundary logic generally, not as ametrics-specific patch. Extended it further with a bare-word enumeration-leak check after finding a second leak of the same underlying shape.tools/build-user-guide/html_sop_edits.py/sync-html-content.pywhosenewtext encoded facts later corrected elsewhere — each was silently reintroducing already-fixed content on every subsequent--apply. Root-caused and fixed at the source rather than patched again in the HTML.Release:
cli/konductor-rs'sCargo.toml/Cargo.lockand the top-levelVERSIONfile to 1.0.4, with a new[1.0.4]CHANGELOG.mdentry. This branch was rebased ontomainafter PR fix(telemetry): scoped agent telemetry for Kiro v2/v3 and Claude #20 (fix/telemetry-kiro-v2-v3) — earlier expected not to merge — actually merged and landed as the real, published1.0.3. That PR's own[1.0.3]CHANGELOG section (telemetry hook wiring, mcp/README.md drift) is left untouched above this entry; this release is 1.0.4, not a second claim on 1.0.3.Fixes # (issue)
Type of Change
cli/) change — Rust or PythonTesting
cli/changed:cd cli && make testpasses (Rust + Python + conformance suites) — full suite green after the rebase onto PR fix(telemetry): scoped agent telemetry for Kiro v2/v3 and Claude #20's merged, substantially-rewrittencli.rs/dispatch.rs/doctor.rs/install.rs, confirming every fix's intent survived relocation into the new upstream code structure, not just that it compiledkonductor --help,konductor init/metrics/config(gated, exit 64, "not currently available"), and each with its escape hatch set (real behavior confirmed —initwrote real files to a scratch target,metricsreached its stub)Checklist
init/metricsmirroring the existingconfigtest pattern; added a regression test for the SOP/skill double-count exclusion (order-independent); added a serializing-lock guard to a test that raced its siblings over the same env var; updated one test whose assertion no longer held onceconfig's doctor check was removedNotes for Reviewers
chore: release 1.0.4commit (version bump + changelog) is intentionally separate from the substantivefix:commits and is expected to be squashed into the CR or folded into one of them at merge — it's release bookkeeping, not an independent change.docs/user-guide/'s version strings are deliberately still pinned at1.0.0, unrelated to this bump — a standing, documented decision (seenotes.md), not an oversight.