feat: improve create TUI model setup - #2164
Merged
Merged
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #2164 +/- ##
============================================
- Coverage 97.25% 97.22% -0.04%
============================================
Files 508 508
Lines 33902 34115 +213
============================================
+ Hits 32972 33168 +196
- Misses 930 947 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Nice work. I traced the credential-name plumbing end-to-end and everything hangs together:
- The wizard's per-provider
configsmap means switching providers no longer clobbers what the user typed for another provider, and the API key ispassword-masked inFormTextInput+ stripped from the review summary (verified by the new tests). credentialFor()correctly returnsundefinedfor bedrock and for an empty-key LiteLLM, and throws only for openai/gemini with a missing key — a state the model step'sonNextwon't allow the user to reach, sosummaryOf's render-time call is safe.- The
credentialName→ placeholderapiKeyArn: "credential:<name>"swap insrc/assets/cdk/bin/cdk.tscleanly avoids widening the pinned CDK schema, andAgentCoreStackre-parses with the resolved (deployed or deterministic same-account) ARN before it reachesAgentCoreApplication, soAgentCoreHarnessRole'sapiKeyArn.split('/').pop()derives the right credential name for the IAM policy. - Schema change in
projectSchemas/harness.tsmakesapiKeyArnandcredentialNamemutually exclusive and keepsapiKeyArn-or-credentialNamerequired for openai/gemini — with tests covering both branches.export.tscorrectly prefers the explicitcredentialNameover the ARN-parsed fallback and reuses an already-declared project credential. - Tests use real temp dirs and
TestCoreClient— no fs / manager mocking creeping in.
No changes requested from me.
notgitika
force-pushed
the
feat/project-create-tui-model-selection
branch
from
September 1, 2026 23:20
9480ccb to
e2a6f99
Compare
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
notgitika
marked this pull request as ready for review
September 1, 2026 23:26
AlexanderRichey
approved these changes
Sep 2, 2026
aidandaly24
added a commit
to aidandaly24/agentcore-cli
that referenced
this pull request
Sep 2, 2026
aws#2163 made ProjectEvent a discriminated union and updated the create wizard along with two of the three mocks in this file. The third belongs to a test aws#2164 added 112 seconds earlier, so aws#2163's branch could not see it: both PRs were green alone and only the merged pair fails typecheck and the spinner test. Same one-line change aws#2163 already made twice here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the project create TUI model selection and spacing.
Tested the TUI manually