fix(core): unnecessary warnings around builtins and AZs - #38673
Open
rix0rrr wants to merge 6 commits into
Open
Conversation
The built-in CloudFormation Validation plugin produces some warnings that are unhelpful: - Unknown built-in functions: there are functions that are unknown to the plugin, and they are potentially not enumerable. Given that the chances of mistyping a function name are tiny if you are using CDK (99% of the time you are not typing them directly anyway), we silence this warning. Annoying and unlikely to happen. Silence always. - The plugin validates that templates don't contain hardcoded AZ names, because that limits portability. This makes perfect sense if you author your templates, but not necessarily if the templates are generated. CDK-generated templates may safely contain hardcoded AZ names. What we are trying to detect is whether a user hardcoded AZ names in CDK. Silence that rule if it looks like the user used the correct code paths to query the available AZs.
Contributor
|
PRs without a linked issue will receive lower priority for review and merging. Please update the description to follow the PR template and include a line like |
aws-cdk-automation
previously requested changes
Aug 26, 2026
aws-cdk-automation
dismissed
their stale review
August 28, 2026 08:00
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
…to huijbers/silence-warnings
aws-cdk-automation
temporarily deployed
to
automation
August 31, 2026 12:43 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
August 31, 2026 12:43 — with
GitHub Actions
Inactive
mrgrain
approved these changes
Sep 2, 2026
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The built-in CloudFormation Validation plugin produces some warnings that are unhelpful:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license