Skip to content

fix(core): unnecessary warnings around builtins and AZs - #38673

Open
rix0rrr wants to merge 6 commits into
mainfrom
huijbers/silence-warnings
Open

fix(core): unnecessary warnings around builtins and AZs#38673
rix0rrr wants to merge 6 commits into
mainfrom
huijbers/silence-warnings

Conversation

@rix0rrr

@rix0rrr rix0rrr commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

The built-in CloudFormation Validation plugin produces some warnings that are unhelpful:

  • Unknown built-in functions: there are functions that are unknown to the plugin, and they are potentially not enumerable. Given that the chances of mistyping a function name are tiny if you are using CDK (99% of the time you are not typing them directly anyway), we silence this warning. Annoying and unlikely to happen. Silence always.
  • The plugin validates that templates don't contain hardcoded AZ names, because that limits portability. This makes perfect sense if you author your templates, but not necessarily if the templates are generated. CDK-generated templates may safely contain hardcoded AZ names. What we are trying to detect is whether a user hardcoded AZ names in CDK. Silence that rule if it looks like the user used the correct code paths to query the available AZs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The built-in CloudFormation Validation plugin produces some warnings
that are unhelpful:

- Unknown built-in functions: there are functions that are unknown to
  the plugin, and they are potentially not enumerable. Given that the
  chances of mistyping a function name are tiny if you are using CDK
  (99% of the time you are not typing them directly anyway), we silence
  this warning. Annoying and unlikely to happen. Silence always.
- The plugin validates that templates don't contain hardcoded AZ names,
  because that limits portability. This makes perfect sense if you
  author your templates, but not necessarily if the templates are
  generated. CDK-generated templates may safely contain hardcoded AZ
  names. What we are trying to detect is whether a user hardcoded AZ
  names in CDK. Silence that rule if it looks like the user used the
  correct code paths to query the available AZs.
@rix0rrr
rix0rrr requested a review from a team as a code owner August 26, 2026 13:34
@github-actions github-actions Bot added the p2 label Aug 26, 2026
@rix0rrr
rix0rrr requested a review from a team August 26, 2026 13:34
@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This pull request description does not follow the correct template structure.

PRs without a linked issue will receive lower priority for review and merging. Please update the description to follow the PR template and include a line like Closes #123 in the Issue section. If no existing issue matches your change, create one first.

@aws-cdk-automation aws-cdk-automation left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Aug 28, 2026
@aws-cdk-automation
aws-cdk-automation dismissed their stale review August 28, 2026 08:00

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify

mergify Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants