fix(cloudfront): metrics not including correct region config - #38688
Open
georeeve wants to merge 3 commits into
Open
fix(cloudfront): metrics not including correct region config#38688georeeve wants to merge 3 commits into
georeeve wants to merge 3 commits into
Conversation
aws-cdk-automation
requested changes
Aug 27, 2026
Collaborator
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
Contributor
Author
|
Exemption Request - The existing integration tests cover the metrics just fine (and I have updated the snapshots to match the new defaults), just the metrics weren't working on CloudWatch due to the missing region props. |
aws-cdk-automation
temporarily deployed
to
automation
August 28, 2026 07:52 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
August 28, 2026 07:52 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
August 28, 2026 07:54 — with
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
August 28, 2026 07:54 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #19245.
Reason for this change
CDK currently does not include the required
Region: 'Global'dimension in the dimensions object for its CloudFront metric() functions. This means the metrics do not work without having to overwrite the dimensions object manually (losing the benefit of the distribution ID being automatically populated).I have also set the
regionprop to default tous-east-1, as this is also required. It saves the client from having to specify it manually, although at least that doesn't involve overwriting the object.https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/programming-cloudwatch-metrics.html#cloudfront-metrics-global-values
Description of changes
Add
Region: 'Global'dimension, andregion: 'us-east-1'by default to code and tests.Describe any new or updated permissions being added
Description of how you validated changes
Manual testing and running the test suite
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license