fix(otel): fix continuation span start time#542
Merged
Conversation
SilanHe
previously approved these changes
Jul 16, 2026
Contributor
|
can you merge after the tests pass? |
Contributor
|
Can we have a case assert on the start time? |
zhongkechen
previously approved these changes
Jul 17, 2026
nvasiu
force-pushed
the
fix-otel-continuation-span-start-time
branch
from
July 17, 2026 16:48
bc5d2d9 to
2b429b9
Compare
zhongkechen
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Update the continuation span's start time to use the operation's start time.
Current behaviour:
When
on_operation_endcontinues a span from a previous invocation, it creates a span withstart_time=datetime.now(). But the span's end time is set to theend_timerecorded in the operation info.If an operation quickly finishes before the span is started,
end_timewill be before thedatetime.now()call, resulting in a negative span duration.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.