Repository navigation
ci: remove the CircleCI config - #10
Merged
Merged
Conversation
The config ran `dotnet build`, which does not support the legacy non-SDK csproj format both projects use, so it could never build this solution. It also predates the GitHub Actions workflow, which now builds Debug and Release on every pull request and push to master. Removing it leaves one working pipeline rather than one working and one permanently failing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SKZ2gugmpaYSHPS7LR5Xjg
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
.circleci/config.yml, which could never build this solution and is now superseded by the GitHub Actions workflow added in #9.Why
The configuration was, in full:
It runs
dotnet build, which does not support the legacy non-SDK.csprojformat that bothMemoryXandMemoryXTestuse — thedotnetCLI requires SDK-style projects. Building this solution needs MSBuild, which is why the Actions workflow uses it.The workflow merged in #9 now builds
DebugandReleaseon every pull request and on every push tomaster, and is green onmaster. Keeping the CircleCI configuration alongside it would leave one working pipeline and one that cannot succeed.Changes
.circleci/config.yml(the only file under.circleci/).No other file in the repository referenced CircleCI, so nothing dangles — the README badge added in #9 points at GitHub Actions.
Testing
A pure deletion with no build-input changes, so the checks on this PR re-confirm that
MemoryX.slnstill builds in both configurations without the CircleCI configuration present.🤖 Generated with Claude Code
https://claude.ai/code/session_01SKZ2gugmpaYSHPS7LR5Xjg
Generated by Claude Code