Keep dark mode surfaces on the chassis - #119
Conversation
The generated-link carbon sheet and header identity mark stayed cream after the dark bench rebuild. Dark theme now uses a carbon sheet and charcoal mark, and a Playwright check guards those backgrounds. Co-authored-by: aanishbhirud <aanishbhirud@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying agent-render with
|
| Latest commit: |
7da4ef7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c0589ae7.agent-render.pages.dev |
| Branch Preview URL: | https://cursor-fix-dark-mode-light-s.agent-render.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 203ef2b. Configure here.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 203ef2b257
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The identity-mark assertion only sampled backgroundColor, which is transparent when the dark mark uses a linear-gradient. The check now uses the brightest opaque stop from the painted surface. Co-authored-by: aanishbhirud <aanishbhirud@gmail.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Verified against Files Reviewed (4 files)
Validation was not executed in this read-only review; findings are based on static inspection. Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 |

The generated-link result panel and header identity mark stayed cream after the dark bench rebuild, so a dark-mode page still flashed a light paper sheet.
This keeps those surfaces on the chassis in dark mode:
A Playwright check asserts the mark and generated-link backgrounds stay below the light-surface luminance threshold in dark mode.
Test plan
/in dark mode, generate a link, and confirm the result panel matches the chassisCI=1 npx playwright test tests/e2e/viewer.spec.ts --project=chromium— 33 passed, including the new luminance checkWalkthrough
Before (cream transfer stock on a dark page):
After (same panel on the chassis):
Light mode still uses cream stock: