Repository navigation
Preserve settlement waterfronts and support large preview links - #85
Merged
Merged
Conversation
✅ Deploy Preview for bazgaars-fmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
barrulus
marked this pull request as ready for review
October 18, 2026 16:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FMG burg markers can be kilometres from their associated river or coast. The old marker-centred survey omitted that water, so ports such as Kindum rendered as inland towns; larger surveys could also fail the preview-link size limit.
Export explicit waterfront relationships independently of port status, include the associated river and shore with adequate survey coverage, and encode coordinates as lossless tuples. Large inputs use URL fragments so they do not hit HTTP request-size limits.
Validation: 135 preview tests pass, including the four Lougy settlements and Kindum from Moncyia; TypeScript, production build and formatting pass. Deploy the corresponding settlemaker-web update before releasing these links.