-
Notifications
You must be signed in to change notification settings - Fork 18
feat(b20-asset): ERC-8056 scaled multiplier (scheduled updates + conformance) #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robriks
wants to merge
2
commits into
main
Choose a base branch
from
markusosterlund/bop-431-erc8056-scaled-multiplier
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // SPDX-License-Identifier: MIT | ||
| pragma solidity >=0.8.20 <0.9.0; | ||
|
|
||
| /// @title IERC165 | ||
| /// @author Ethereum (ERC-165) | ||
| /// | ||
| /// @notice Standard interface-detection interface. | ||
| /// | ||
| /// @dev Interface ID: `0x01ffc9a7`. Declared locally because base-std carries no external | ||
| /// dependency that provides it (ERC-165 is greenfield here). | ||
| interface IERC165 { | ||
| /// @notice Whether this contract implements the interface defined by `interfaceId`. | ||
| /// | ||
| /// @param interfaceId The interface identifier, per ERC-165. | ||
| /// | ||
| /// @return `true` if the contract implements `interfaceId` and `interfaceId != 0xffffffff`. | ||
| function supportsInterface(bytes4 interfaceId) external view returns (bool); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // SPDX-License-Identifier: MIT | ||
| pragma solidity >=0.8.20 <0.9.0; | ||
|
|
||
| /// @title IScaledUIAmount | ||
| /// @author Ethereum (ERC-8056) | ||
| /// | ||
| /// @notice ERC-8056 core interface. A compliant token exposes an updatable, cosmetic | ||
| /// `uiMultiplier` (18-decimal WAD, `1e18 = 1.0`) that rescales the *displayed* | ||
| /// balance without minting, transferring, or rewriting any raw balance. | ||
| /// | ||
| /// @dev Interface ID: `0xa60bf13d` — self-checked via `type(IScaledUIAmount).interfaceId`, which | ||
| /// is derived solely from `uiMultiplier()`. ERC-8056 also defines an OPTIONAL | ||
| /// `TransferWithUIAmount(address,address,uint256,uint256)` event; B20 deliberately omits it | ||
| /// (D9: no per-transfer scaled event, since the multiplier is cosmetic and scaled balances | ||
| /// are reconstructable off-chain). Events do not contribute to the interface ID, so omitting | ||
| /// it leaves `0xa60bf13d` unchanged. | ||
| interface IScaledUIAmount { | ||
| /// @notice Emitted when the UI multiplier is updated. | ||
| event UIMultiplierUpdated(uint256 oldMultiplier, uint256 newMultiplier, uint256 effectiveAtTimestamp); | ||
|
|
||
| /// @notice Returns the current UI multiplier. Multiplier is represented with 18 decimals (`1e18 = 1.0`). | ||
| /// @return Current UI multiplier. | ||
| function uiMultiplier() external view returns (uint256); | ||
| } | ||
|
|
||
| /// @title IScaledUIAmountNewUIMultiplier | ||
| /// @author Ethereum (ERC-8056) | ||
| /// | ||
| /// @notice "Pending Multiplier" extension required by ERC-8056 | ||
| /// | ||
| /// @dev Interface ID: `0x4bd27648`. | ||
| interface IScaledUIAmountNewUIMultiplier { | ||
| /// @notice Returns the pending UI multiplier scheduled to take effect at `effectiveAt`. | ||
| /// Multiplier is represented with 18 decimals (`1e18 = 1.0`). | ||
| /// @return Pending UI multiplier. | ||
| function newUIMultiplier() external view returns (uint256); | ||
|
|
||
| /// @notice Returns the timestamp at which the pending multiplier becomes effective. | ||
| /// @return Effective-at timestamp. | ||
| function effectiveAt() external view returns (uint256); | ||
| } | ||
|
|
||
| /// @title IScaledUIAmountBalances | ||
| /// @author Ethereum (ERC-8056) | ||
| /// | ||
| /// @notice ERC-8056 optional "Balances" extension for on-chain UI balance queries. | ||
| /// | ||
| /// @dev Interface ID: `0xd890fd71`. | ||
| interface IScaledUIAmountBalances { | ||
| /// @notice Returns the UI-adjusted balance of an account. | ||
| /// | ||
| /// @param account Account whose UI-adjusted balance is being queried. | ||
| /// | ||
| /// @return UI-adjusted balance. | ||
| function balanceOfUI(address account) external view returns (uint256); | ||
|
|
||
| /// @notice Returns the UI-adjusted total supply. | ||
| /// @return UI-adjusted total supply. | ||
| function totalSupplyUI() external view returns (uint256); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can simplify this comment to. Old multiprler scheduled has been cancelled something along those lines