Repository navigation
fix: make decode_table_values robust to dictionary quirks - #76
Merged
Merged
Conversation
vrtornisiello
commented
Oct 5, 2026
vrtornisiello
commented
Collaborator
- Match column names with TRIM, since some dictionaries store them with stray whitespace (e.g. Censo Escolar's "tipo_situacao_funcionamento "), which made the lookup return no entries.
- Reject the dataset's own dictionary table as the target, instead of silently returning an empty list.
- Return an explicit error when no dictionary entries match, instead of an empty list the agent cannot act on.
fix: ensure backticks
chore: sync main with staging
chore: sync main with staging
chore: sync main with staging
chore: sync main with staging
chore: sync main with staging
chore: sync main with staging
chore: sync main with staging
chore: sync main with staging
chore: sync main with staging
chore: sync main with staging
chore: sync main with staging- #73
- Match column names with TRIM, since some dictionaries store them with stray whitespace (e.g. Censo Escolar's "tipo_situacao_funcionamento "), which made the lookup return no entries. - Reject the dataset's own dictionary table as the target, instead of silently returning an empty list. - Return an explicit error when no dictionary entries match, instead of an empty list the agent cannot act on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cover both whitespace cases in the column-name test: a stored name with stray whitespace matched by the model's trimmed name, and a passed name with whitespace. The mock now returns a row so the success path is exercised. Assert the full error message when the dictionary table is passed as the target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.