fix(export): bound GenerateShort's wait for the short service - #447
Open
KillerX wants to merge 1 commit into
Open
fix(export): bound GenerateShort's wait for the short service#447KillerX wants to merge 1 commit into
KillerX wants to merge 1 commit into
Conversation
The status loop had no exit but the job finishing. Each pass costs an activity and a timer — five history events — and it polled every five seconds, so a job stuck in in_progress wrote roughly 3,600 events an hour until the server terminated the execution for exceeding its history limit. The failure that reached the operator said nothing about the job. Extracted as waitForShortJob, which polls every five seconds for the first two minutes and every thirty after that, and gives up at two hours with a non-retryable error naming the job. A stuck job now costs a few hundred events instead of tens of thousands, and a quick job is still noticed within five seconds. Two hours matches the ceiling the vizualizer wait already uses. Nothing about the short service suggests a legitimate job runs longer; if one does, the error says so rather than the execution disappearing. The extraction is also what makes it testable: three tests drive the loop through the test environment's clock, including the stuck-job case, which is not reachable while the loop is inline in a workflow that first has to get through export data, scene detection and a child workflow. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8/n of a stack. Base:
refactor/remove-dynamic-trigger-form(#446). First of the Unbounded workflow histories findings.The status loop had no exit but the job finishing. Each pass costs an activity and a timer — five history events — and it polled every five seconds, so a job stuck in
in_progresswrote roughly 3,600 events an hour until the server terminated the execution for exceeding its history limit. The failure that reached the operator said nothing about the job.Extracted as
waitForShortJob: five seconds for the first two minutes, thirty after that, and it gives up at two hours with a non-retryable error naming the job. A stuck job now costs a few hundred events instead of tens of thousands, and a quick job is still noticed within five seconds. Two hours matches the ceiling the vizualizer wait already uses.The extraction is also what makes it testable — three tests drive the loop through the test environment's clock, including the stuck-job case, which is not reachable while the loop is inline in a workflow that first has to get through export data, scene detection and a child workflow.
🤖 Generated with Claude Code