refactor(vb_export): remove the HAP v1 export - #454
Merged
Conversation
KillerX
force-pushed
the
refactor/remove-hap-v1
branch
from
August 13, 2026 08:49
76719f0 to
563204f
Compare
KillerX
force-pushed
the
refactor/remove-hap-v1
branch
from
August 13, 2026 13:26
563204f to
fe8b695
Compare
KillerX
force-pushed
the
refactor/remove-hap-v1
branch
from
August 14, 2026 06:37
fe8b695 to
e007e12
Compare
KillerX
force-pushed
the
refactor/remove-hap-v1
branch
from
August 14, 2026 07:15
e007e12 to
41ea201
Compare
KillerX
force-pushed
the
refactor/remove-hap-v1
branch
from
August 14, 2026 08:16
41ea201 to
05ef663
Compare
KillerX
force-pushed
the
refactor/remove-hap-v1
branch
from
August 14, 2026 08:39
05ef663 to
aaba51e
Compare
KillerX
force-pushed
the
refactor/remove-hap-v1
branch
from
August 14, 2026 08:54
aaba51e to
598e839
Compare
KillerX
force-pushed
the
refactor/remove-hap-v1
branch
from
August 14, 2026 09:18
598e839 to
bb17a2f
Compare
KillerX
force-pushed
the
refactor/remove-hap-v1
branch
from
August 14, 2026 10:00
bb17a2f to
a4a9da0
Compare
KillerX
force-pushed
the
refactor/remove-hap-v1
branch
from
August 14, 2026 10:04
a4a9da0 to
9493970
Compare
VBExportToHippo produced HAP by copying the video into an Adobe Media Encoder watch folder on Isilon — system/transcodetemp/hippo/hapqhippo/in, or hapalphahippo/in for alpha — and then polling the matching out folder with WaitForFile until AME had written something there. VBExportToHippoV2 and VBExportToHippoHap do the same encode in process with TranscodeToHAPActivity, which is what the v2 doc comment means when it says it encodes "instead of putting it into a watch folder". Gone with it: the destination, its enum member and its dispatch case, the four watch-folder paths, and the filter in cmd/trigger_ui that hid the v1 destination from the form — hiding it in the UI was the previous step in retiring it, and there is nothing left to hide. Also gone is the special case that excluded hippo from audio normalisation. v1 delivered no audio at all, since AME's FlexRes output had none; the two HAP flows that replace it carry audio, so they normalise like everything else. Only CasparCG is excluded now. The destination string "hippo" is no longer a member of the enum, so a caller still asking for it gets rejected by VBExport rather than quietly running the watch-folder flow. The UI has not offered it for a while, so the remaining callers would be direct API calls. activities.Util.WaitForFile stays — ImportAudioFileFromReaper still uses it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
KillerX
force-pushed
the
refactor/remove-hap-v1
branch
from
August 14, 2026 10:44
9493970 to
6f1f74e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
15/n of a stack. Base:
refactor/ffmpeg-run-job(#453).VBExportToHippoproduced HAP by copying the video into an Adobe Media Encoder watch folder on Isilon —system/transcodetemp/hippo/hapqhippo/in, orhapalphahippo/infor alpha — then polling the matchingoutfolder withWaitForFileuntil AME had written something there.VBExportToHippoV2andVBExportToHippoHapdo the same encode in process withTranscodeToHAPActivity. That is what v2's doc comment means by encoding "instead of putting it into a watch folder".Removed: the workflow, the destination and its enum member and dispatch case, the four watch-folder paths, and the filter in
cmd/trigger_ui/vb.gothat hid the v1 destination from the form. Hiding it in the UI was the previous step in retiring it; there is nothing left to hide.Also removed: the special case that excluded hippo from audio normalisation. v1 delivered no audio at all — AME's FlexRes output had none — so it was skipped. The two HAP flows that replace it carry audio, so they normalise like every other destination. Only CasparCG is excluded now.
One thing to be aware of:
"hippo"is no longer a member of theDestinationenum, so a caller still asking for it is rejected byVBExportrather than quietly running the watch-folder flow. The UI has not offered it for a while, so any remaining callers would be direct API calls.activities.Util.WaitForFilestays —ImportAudioFileFromReaperstill uses it.make testgreen,go vetclean, and no reference to the AME watch folders remains anywhere in the tree.🤖 Generated with Claude Code