Repository navigation
35151 allow BC/BEN NR legal type mismatch for amalgamation - #4853
Merged
Merged
Conversation
mruff-aeq
requested review from
kialj876,
meawong and
vysakh-menon-aot
and removed request for
kialj876
October 8, 2026 15:10
meawong
approved these changes
Oct 8, 2026
meawong
left a comment
meawong
left a comment
Collaborator
There was a problem hiding this comment.
could you address the Sonar issue if it’s a quick fix? otherwise LGTM
Collaborator
Author
|
Addressed the Sonar issue: flattened the early-return chain in validate_name_request so cognitive complexity is back under the limit. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issue:*bcgov/entity#35151
Description of changes: Regular amalgamations with a BC or BEN resulting type now accept a Name Request of either type (RAID #820).