Skip to content

35155 - Fix Correction of Name with No NR #4855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meawong merged 1 commit into from
Oct 9, 2026
Merged

35155 - Fix Correction of Name with No NR #4855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions legal-api/src/legal_api/services/filings/validations/correction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,9 @@ def _validate_name_request(business, filing_dict, new_legal_type, filing_type):
msg = []
if filing_dict.get("filing", {}).get("correction", {}).get("nameRequest", {}).get("nrNumber", None):
msg.extend(validate_name_request(filing_dict, new_legal_type or business.legal_type, filing_type))
else:
elif new_legal_type:
valid_names = [business.legal_name]
if (new_legal_type and
(new_numbered_name := Business.generate_numbered_legal_name(new_legal_type, business.identifier))):
if new_numbered_name := Business.generate_numbered_legal_name(new_legal_type, business.identifier):
# if existing legal_name is a numbered name and if type has changed
# then the legal name get updated according to the new legal type
valid_names.append(new_numbered_name)
Expand Down
24 changes: 24 additions & 0 deletions legal-api/tests/unit/services/filings/validations/test_correction_ia.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,30 @@ def test_valid_ia_correction(session, app, jwt):
assert None is err


def test_valid_ia_correction_allows_legal_name_typo_correction_without_nr(session, app, jwt):
"""Test that a valid IA without NR can fix a legal name typo."""
identifier = 'BC1234567'
business = factory_business(identifier, entity_type='BC')
business.legal_name = 'Test Compnay Inc.'
business.save()

corrected_filing = factory_completed_filing(business, INCORPORATION_APPLICATION)

filing = copy.deepcopy(CORRECTION)
filing['filing']['header']['identifier'] = identifier
filing['filing']['correction']['correctedFilingId'] = corrected_filing.id
filing['filing']['correction']['nameRequest'] = {
'nrNumber': '',
'legalName': 'Test Company Inc.',
'legalType': 'BC'
}

with jwt_request_context(app, jwt, [STAFF_ROLE]):
err = validate(business, filing)

assert err is None


@pytest.mark.parametrize('new_name, legal_type, nr_legal_type, nr_type, err_msg', [
('legal_name-BC1234568', 'CP', 'CP', 'BECV', None),
('legal_name-BC1234567_Changed', 'BEN', 'CP', 'BECV',
Expand Down
Loading