Repository navigation
fix(shell): handle whitespace and home paths in worktree completion - #59
Merged
Merged
Conversation
Support Tab after `cd -jw` and `--jump-worktree` with spaces or tabs across shells while preserving attached triggers. Preserve literal selected paths and history recording, quote Nushell suggestions, and extend PowerShell replacement ranges. Document the behavior and add POSIX real-terminal regressions isolated from the Git hook environment. Further cross-shell regression tests will follow separately due to commit size limits. Refs #58
Cover Nushell and PowerShell trailing-whitespace completion, literal quoting, and invalid-argument and history safety for worktree commands. Exercise real Nushell Reedline Tab insertion plus Enter and back navigation in an isolated PTY. Validation: 127 local tests and Windows-target Clippy passed. Native Windows runtime coverage remains for CI after push. Closes #58
Use `compadd -d` to display paths under `HOME` as `~/…` while preserving absolute insertion and fzf-tab preview paths. Cover exact `HOME`, trailing slashes, empty values, directory prefix boundaries, and actual ZLE absolute insertion. Independently verify installed fzf-tab capture, query, and apply behavior. Refs #58
benbenbang
enabled auto-merge (rebase)
September 10, 2026 08:19
github-actions
Bot
added
documentation
Contributor
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worktree completion produced incorrect results after trailing whitespace and displayed verbose Zsh labels for paths under
HOME.HOMEas~/…without changing inserted paths or fzf-tab previews.Closes #58