Repository navigation
feat(cli): classify MCP startup failures and add --verbose alias - #85
Merged
Merged
Conversation
Add safe diagnostics for MCP startup so missing or malformed upstream API keys, unsupported providers, and client configuration errors are classified and surfaced with actionable guidance, without logging credential values or raw error causes. Validate the configured API key by trimming whitespace and rejecting non-printable characters so an invalid key is reported distinctly from a missing one, and ensure an explicit empty CLI key never falls back to an SDK environment key. Introduce a `--verbose` persistent flag as an alias for `--debug`. Either flag now enables debug-level logging and the diagnostic startup category; an explicit `--debug=false --verbose` still logs. Update the debug documentation to cover the alias and the new MCP startup failure guidance, and add tests exercising the initialization logging and the verbose alias behaviour.
benbenbang
enabled auto-merge (rebase)
October 11, 2026 02:58
github-actions
Bot
added
documentation
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add safe diagnostics for MCP startup so missing or malformed upstream API
keys, unsupported providers, and client configuration errors are
classified and surfaced with actionable guidance, without logging
credential values or raw error causes. Validate the configured API key by
trimming whitespace and rejecting non-printable characters so an invalid
key is reported distinctly from a missing one, and ensure an explicit
empty CLI key never falls back to an SDK environment key.
Introduce a
--verbosepersistent flag as an alias for--debug. Eitherflag now enables debug-level logging and the diagnostic startup category;
an explicit
--debug=false --verbosestill logs.Update the debug documentation to cover the alias and the new MCP startup
failure guidance, and add tests exercising the initialization logging and
the verbose alias behaviour.