Repository navigation
test(internal): synchronize stop callback before checking side effects - #89
Merged
Merged
Conversation
The MCP management test previously treated a stop acknowledgement as proof that the deferred callback had finished, which allowed the assertion on the stop counter to race against the callback's completion. **Test Synchronization Improvements:** * Added a cancellation gate that blocks the stop callback until the test explicitly releases it, forcing the acknowledgement to arrive before the callback increments the counter. * Released the gate and joined the HTTP handlers via `server.Close()` before inspecting cancellation side effects, ensuring the deferred callback has run. * Replaced the inline `authenticated && stops.Load() != 1` check with an explicit `wantStops` expectation, making the intended stop count clear for both authenticated and unauthenticated cases.
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP management test previously treated a stop acknowledgement as proof
that the deferred callback had finished, which allowed the assertion on the
stop counter to race against the callback's completion.
Test Synchronization Improvements:
explicitly releases it, forcing the acknowledgement to arrive before the
callback increments the counter.
server.Close()beforeinspecting cancellation side effects, ensuring the deferred callback has
run.
authenticated && stops.Load() != 1check with anexplicit
wantStopsexpectation, making the intended stop count clear forboth authenticated and unauthenticated cases.