Repository navigation
feat(insider-trading)!: make FMP-omittable members optional - #391
Merged
Merged
Conversation
Members that FMP can omit from the insider-trading and institutional-ownership feeds are now optional across the Rust models, Python bindings, and Go SDK, so callers must handle their absence. * InsiderTrade `transaction_type`, `securities_owned`, and `direct_or_indirect` now decode a null or empty value to None; a whitespace-only transaction type is still rejected. * BeneficialOwnershipAcquisition `cusip`, `citizenship_or_place_of_organization`, and `shared_voting_power` decode null to None. * InstitutionalHolding `symbol` decodes null to None. * HolderIndustryBreakdown `industry_title`, `change_in_weight_percentage`, and `performance_percentage` decode null to None, while an empty industry title stays "". * Contract tests now take an explicit nullable-member list rather than treating every member as required and non-null, and re-encode these members as null. BREAKING CHANGE: InsiderTrade, BeneficialOwnershipAcquisition, InstitutionalHolding and HolderIndustryBreakdown members FMP can omit are now optional (Option / pointer / Optional); handle None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Members that FMP can omit from the insider-trading and institutional-ownership
feeds are now optional across the Rust models, Python bindings, and Go SDK, so
callers must handle their absence.
transaction_type,securities_owned, anddirect_or_indirectnow decode a null or empty value to None; a whitespace-only transaction type
is still rejected.
cusip,citizenship_or_place_of_organization,and
shared_voting_powerdecode null to None.symboldecodes null to None.industry_title,change_in_weight_percentage, andperformance_percentagedecode null to None, while an empty industry titlestays "".
every member as required and non-null, and re-encode these members as null.
BREAKING CHANGE: InsiderTrade, BeneficialOwnershipAcquisition, InstitutionalHolding and HolderIndustryBreakdown members FMP can omit are now optional (Option / pointer / Optional); handle None.