Repository navigation
fix(congressional): make aggregate cash and mutual funds optional - #408
Merged
Merged
Conversation
This commit corrects CongressionalMemberNetWorthAggregate decoding after a survey for #407 found cashAndCashEquivalents and mutualFundsAndETFs absent on live rows, so both are now optional and decode as None when the key is missing instead of failing. **Optional members:** * cash_and_cash_equivalents and mutual_funds_and_etfs become Option / pointer / Optional across the Rust, Go, and Python models and must now be handled as nullable. **New typed columns and overflow map:** * Add typed columns pension_and_retirement_assets, other_amount (wire Other), other_assets, salary_and_wages, trusts, and government_securities for the most frequent extra fields. * Keep every remaining untyped column in a new additional_columns map rather than dropping it, so open-ended rows round-trip. **Tests and docs:** * Extend the aggregated fixture and parity tests to cover absent cash, absent mutual funds, typed columns, and additional_columns. * Record the rule and survey in ADR 0033. close #407 BREAKING CHANGE: CongressionalMemberNetWorthAggregate.cash_and_cash_equivalents and mutual_funds_and_etfs are now optional (Option / pointer / Optional); handle None. New typed columns (pension_and_retirement_assets, other_amount for wire Other, other_assets, salary_and_wages, trusts, government_securities) and an additional_columns map are added.
benbenbang
enabled auto-merge (rebase)
October 2, 2026 09:21
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit corrects CongressionalMemberNetWorthAggregate decoding after a survey for #407 found cashAndCashEquivalents and mutualFundsAndETFs absent on live rows, so both are now optional and decode as None when the key is missing instead of failing.
Optional members:
New typed columns and overflow map:
Tests and docs:
close #407
BREAKING CHANGE: CongressionalMemberNetWorthAggregate.cash_and_cash_equivalents and mutual_funds_and_etfs are now optional (Option / pointer / Optional); handle None. New typed columns (pension_and_retirement_assets, other_amount for wire Other, other_assets, salary_and_wages, trusts, government_securities) and an additional_columns map are added.