Repository navigation
ci(go-sdk): report go sdk checks on every pull request - #413
Merged
Merged
Conversation
The pull_request paths filter skipped the whole Go SDK workflow on docs-only PRs, leaving the required `go sdk (ubuntu-latest)` and `go sdk (macos-latest)` checks pending and blocking the merge (PR 412). Pull requests now always start the workflow so the required checks always report. A new `changes` job uses tj-actions/changed-files (pinned to the same commit as pre-commit.yml) to detect Go-relevant files, and every check step is gated on its result via a RUN_GO_CHECKS env flag. An unrelated PR skips the real work but still reports success under the expanded matrix names. Gating happens at the step level rather than with a job-level `if` because a skipped matrix job may not report the expanded check names. Skipped runs fall back to the ubuntu runner since they only echo a message. Detection runs only on pull_request; push keeps its own paths filter and workflow_dispatch always runs the checks. The no-op exclusions for crates/fmp-py/examples and sdk/node/examples are dropped: no include pattern matched those paths. push keeps only !sdk/go/examples/**.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull_request paths filter skipped the whole Go SDK workflow on
docs-only PRs, leaving the required
go sdk (ubuntu-latest)andgo sdk (macos-latest)checks pending and blocking the merge (PR 412).Pull requests now always start the workflow so the required checks
always report. A new
changesjob uses tj-actions/changed-files(pinned to the same commit as pre-commit.yml) to detect Go-relevant
files, and every check step is gated on its result via a RUN_GO_CHECKS
env flag. An unrelated PR skips the real work but still reports success
under the expanded matrix names.
Gating happens at the step level rather than with a job-level
ifbecause a skipped matrix job may not report the expanded check names.
Skipped runs fall back to the ubuntu runner since they only echo a
message. Detection runs only on pull_request; push keeps its own paths
filter and workflow_dispatch always runs the checks.
The no-op exclusions for crates/fmp-py/examples and sdk/node/examples are dropped: no include pattern matched those paths. push keeps only !sdk/go/examples/**.