Repository navigation
docs(error): clarify MissingCredential covers from_env for any base URL - #421
Merged
Merged
Conversation
The MissingCredential variant (Rust `ConfigurationErrorKind` and Go `ConfigurationKindMissingCredential`) is also raised by the `from_env` constructors added in #415 when `FMP_API_KEY` is unset or blank, for any base URL including proxies. The previous docs only mentioned direct FMP access, which was misleading. Update the doc comments in both SDKs to describe both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MissingCredential variant (Rust
ConfigurationErrorKindand GoConfigurationKindMissingCredential) is also raised by thefrom_envconstructors added in #415 when
FMP_API_KEYis unset or blank, for anybase URL including proxies. The previous docs only mentioned direct FMP
access, which was misleading. Update the doc comments in both SDKs to
describe both cases.