Repository navigation
Re-attach relay OK/EOSE handlers after Nostr client is rebuilt on network switch - #981
Merged
Merged
Conversation
Implements a manual-picker response to issue #971 without automatic fallback: when the currently selected primary indexer fails to respond to a request, MempoolSpaceIndexerApi now calls INetworkService.NotifyIndexerUnreachable, which marks the indexer offline and raises an IndexerUnreachable event (debounced per indexer to avoid flooding subscribers from concurrent failing requests). In src/design/App, ShellViewModel subscribes to this event and shows a new IndexerUnreachableModal directly (no background retry loop), letting the user pick a different configured indexer or add a custom URL. Selecting an indexer just sets it as primary and persists it - no automatic verification/fallback chain is attempted.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #980
Switching network calls CloseClientConnection(), which disposes the Nostr multi-relay client. RelaySubscriptionsHandling only attached its OK/EOSE handlers in its constructor, so after a switch nothing listened to the new client. Deploying a project then failed with 'Nostr profile creation timed out after 30s' until the app was restarted. Relays were healthy; the app just never observed their OK/EOSE responses.
Not yet covered by an automated test. Manual check: switch network in Settings, then deploy a project without restarting.