Repository navigation
Redirect multi-part invoice payments to pay-from-wallet - #985
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an on-chain invoice is paid in 2+ transactions, the invest flow builds the investment from the funding address, which spends every coin on it. The fee is sized for one input, so signing fails with "Insufficient funds".
Change (src/design/App, PaymentFlowViewModel)
PaidInPartsscreen. It explains the payment arrived in multiple parts, the funds are now in the wallet, and the user should pay from the wallet. It also says to add funds to the wallet, not to send more to the invoice address. A button returns to the wallet selector.AddInputsAndSignTransactiondoes not exclude unconfirmed UTXOs, so no confirmation caveat is shown.Supersedes #930. No SDK, estimator or web app changes, and no top-up loop.
Tests
PaymentFlowMultiPartPaymentTests(single coin, multi coin, timeout with balance increase, timeout without).App.Desktopbuilds clean.Manual signet test plan