Skip to content

fix: keep request cards readable across themes and narrow layouts - #6

Merged
jmecom merged 1 commit into
block:mainfrom
Gussy:codex/alto-request-cards
Oct 16, 2026
Merged

jmecom merged 1 commit into
block:mainfrom
Gussy:codex/alto-request-cards

Conversation

@Gussy

@Gussy Gussy commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Approval and question cards use fixed light backgrounds and low-contrast labels that become difficult to read in dark mode. Use the existing theme text and panel colors for cards, details, and form controls, with visible focus and selected states.

Wrap long content and action buttons within narrow cards, and use the existing spacing and radius tokens. Lower the styling-audit baseline to reflect the removed raw colors.

Validation

  • VITEST_MAX_WORKERS=4 npm run check: 1,038 tests passed, 2 skipped; styling audit, TypeScript, and production build passed.
  • Hidden Chromium coverage checks 48 combinations: eight request/proposal variants, light and dark themes, and 360/480/1,000 px widths.
  • Checks cover overflow, control bounds, text and placeholder contrast of at least 4.5:1, selected indicators, and focus styling. Keyboard focus states are emulated in a hidden window.

Screenshots

Synthetic browser fixtures at 360 px, with long content to exercise wrapping:

Light Dark
Approval Screenshot Screenshot
Question Screenshot Screenshot

@Gussy
Gussy requested a review from jmecom as a code owner October 16, 2026 23:24
@jmecom
jmecom merged commit d5b218f into block:main Oct 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants