Skip to content

replay: pin buzz's unnamed ADD FOREIGN KEY as executed #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kiran01bm merged 3 commits into from
Oct 30, 2026
Merged

replay: pin buzz's unnamed ADD FOREIGN KEY as executed #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61ead0c
replay: pin buzz's unnamed ADD FOREIGN KEY as executed
Kiran01bm Oct 24, 2026
ca66370
Merge origin/main into kiran01bm/replay-buzz-unnamed-fk-pin
Kiran01bm Oct 29, 2026
5867dfb
replay: say the fkey name follows the server's truncation and numbering
Kiran01bm Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion replay/buzz/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ behaviors worth knowing when reading the results:
- `CREATE INDEX IF NOT EXISTS` is refused by design — a name-only no-op cannot prove
the existing index is valid or even the requested one.
- Buzz's unnamed `ADD FOREIGN KEY` executes via the safer `NOT VALID` + `VALIDATE`
sequence, under the name the server would have chosen.
sequence: the `VALIDATE` step has to name the constraint, so pg-sprite states the
name PostgreSQL would choose — `<table>_<columns>_fkey`, truncated to the identifier
limit and numbered past a name already taken, as the server does. Here that is
`moderation_reports_community_id_action_id_fkey`.
- Every `DROP COLUMN`, `DROP CONSTRAINT`, and `DROP NOT NULL` is refused by design
(`destructive-change`): the replay never passes `--allow-destructive`, so it pins
the refusal and advances the history through psql.
6 changes: 3 additions & 3 deletions replay/buzz/assessment.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@
0006 94-118 refuse:unsupported-statement:no-online-safety-problem:declarative-front-door
0006 120-121 execute
0006 122-124 execute
# Unnamed ADD FOREIGN KEY: the safer NOT VALID + VALIDATE sequence needs a
# constraint name to reference; the same constraint with CONSTRAINT <name> executes.
0006 128-130 refuse:not-native-safe-rewrite-required:capability-boundary
# Unnamed ADD FOREIGN KEY: executes as NOT VALID + VALIDATE under the name
# PostgreSQL would choose (moderation_reports_community_id_action_id_fkey).
0006 128-130 execute
0007 12-12 psql
0007 14-22 refuse:unsupported-statement:no-online-safety-problem:declarative-front-door
0007 26-27 execute
Expand Down
Loading